Re: [PATCH] virtio: Add missing kerneldoc for virtio_dma_buf_attach
jiang.peng9 at zte.com.cn
jiang.peng9 at zte.com.cn
Sat Jul 5 02:14:55 UTC 2025
> > diff --git a/drivers/virtio/virtio_dma_buf.c b/drivers/virtio/> virtio_dma_buf.c
> > index 3fe1d03b0645..18d261ba5197 100644
> > --- a/drivers/virtio/virtio_dma_buf.c
> > +++ b/drivers/virtio/virtio_dma_buf.c
> > @@ -35,7 +35,16 @@ struct dma_buf *virtio_dma_buf_export
> > EXPORT_SYMBOL(virtio_dma_buf_export);
> >
> > /**
> > - * virtio_dma_buf_attach - mandatory attach callback for virtio dma-bufs
> > + * virtio_dma_buf_attach - Mandatory attach callback for virtio dma-bufs
>
> Read kernel-doc.rst. Missing ()
>
> > + * @dma_buf: Pointer to the shared dma-buf structure
> > + * @attach: Pointer to the newly created attachment metadata
> > + *
> > + * Description: Implements the standard dma-buf attach operation for > virtio devices.
>
> That's not kerneldoc. Which part of kernel-doc document documents such
> syntax?
Thanks so much for your time and feedback! I’ve made two specific fixes based on your notes:
Added () to the function name in the kerneldoc comment (e.g., virtio_dma_buf_attach() instead of virtio_dma_buf_attach).
Removed the redundant "Description:" label and simplified the explanation.
Let me know if you need anything else in the meantime!
Best regards,
Peng
More information about the dri-devel
mailing list