[PATCH v3 1/7] gpu: nova-core: Add code comments related to devinit

Miguel Ojeda miguel.ojeda.sandonis at gmail.com
Sun Jul 6 13:42:13 UTC 2025


On Wed, Jul 2, 2025 at 1:04 PM Alexandre Courbot <acourbot at nvidia.com> wrote:
>
> +        // Check that FWSEC has lowered its protection level before reading the GFW_BOOT status.

`GFW_BOOT` (another one below), since it is written like that above.

> -/* PGC6 */
> +/*
> + * PGC6 register space.
> + *
> + * `GC6` is a GPU low-power state where VRAM is in self-refresh and the GPU is powered down (except
> + * for power rails needed to keep self-refresh working and important registers and hardware
> + * blocks).
> + *
> + * These scratch registers remain powered on even in a low-power state and have a designated group
> + * number.
> + */

I noticed the file uses `/*` in a couple files -- could `//` be used
or there is a reason for it?

(I guess maybe in a different series, since it is already there for
PMC in mainline. It could be a good first issue.)

The idea is to only use `/*` when `//` cannot be used, e.g. within
code, so that they have a different purpose.

Cheers,
Miguel


More information about the dri-devel mailing list