[PATCH 2/2] drm/nouveau: Remove nvkm_gsp_fwif.enable

[Ben Skeggs]

On 7/15/25 02:04, M Henning wrote:

> On Sun, Jul 13, 2025 at 11:19 PM Ben Skeggs <bskeggs at nvidia.com> wrote:
>> Yeah, the GPUs that don't support GSP-RM can't hit the code that used
>> fwif.enable anyway, so the series should be fine as it is.
> We're actually talking about the reverse case. That is, on Ada what
> happens if you set nouveau.config=NvGspRm=0 on the kernel command
> line?

The last entry in fwif[] for GPUs prior to Ada is one that always 
succeeds, and sets up some minimal GSP stuff that's needed for booting 
the pre-GSP-RM firmwares.  Ada onwards lack this, and the driver will 
cleanly fail to load as if no firmware were present.

The error message could be better for sure, and you can just add an 
nvkm_error(&gsp->subdev, ...) after the attempt to call 
nvkm_firmware_load() in subdev/gsp/base.c.

This should work fine without needing to add any kind of "needs GSP-RM" 
field anywhere.

Ben.