[PATCH v2 15/15] backlight: Do not include <linux/fb.h> in header file

[Thomas Zimmermann]

Hi

Am 15.07.25 um 15:22 schrieb Simona Vetter:
> On Tue, Jul 15, 2025 at 02:24:52PM +0200, Thomas Zimmermann wrote:
>> The backlight interfaces don't require anything from <linux/fb.h>, so
>> don't include it.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
> I like this very much.
>
> Reviewed-by: Simona Vetter <simona.vetter at ffwll.ch>

Thanks for reviewing. backlight.h is also the last major header file the 
includes <linux/fb.h>. Not including it here will free many other files 
from the dependency.

>
> I guess also my Acked-by for merging the entire pile through the backlight
> subsystem, that's probably the easiest path to land this all.

Yeah, that was the plan.

Best regards
Thomas

>
> Cheers, Sima
>
>> ---
>>   include/linux/backlight.h | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/include/linux/backlight.h b/include/linux/backlight.h
>> index 10e626db7eee..f29a9ef1052e 100644
>> --- a/include/linux/backlight.h
>> +++ b/include/linux/backlight.h
>> @@ -10,7 +10,6 @@
>>   #define _LINUX_BACKLIGHT_H
>>   
>>   #include <linux/device.h>
>> -#include <linux/fb.h>
>>   #include <linux/mutex.h>
>>   #include <linux/types.h>
>>   
>> -- 
>> 2.50.0
>>

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)