[PATCH v2 02/19] gpu: nova-core: register: fix typo

Boqun Feng boqun.feng at gmail.com
Fri Jul 18 19:05:00 UTC 2025


On Fri, Jul 18, 2025 at 04:26:07PM +0900, Alexandre Courbot wrote:
> A space was missing between arguments in this invocation.
> 

It's obvious up to driver and Nova folks, but I feel this commit better
folded into another patch or we make the title a bit more clear, say:

gpu: nova-core: register: add the missing space in register!()

Otherwise my fear is we're going to end up with a few "fix typo" commits
in the future.

Anyway

Reviewed-by: Boqun Feng <boqun.feng at gmail.com>

Regards,
Boqun

> Signed-off-by: Alexandre Courbot <acourbot at nvidia.com>
> ---
>  drivers/gpu/nova-core/regs/macros.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/nova-core/regs/macros.rs b/drivers/gpu/nova-core/regs/macros.rs
> index 864d1e83bed2979f5661e038f4c9fd87d33f69a7..93e9055d5ebd5f78ea534aafd44d884da0fce345 100644
> --- a/drivers/gpu/nova-core/regs/macros.rs
> +++ b/drivers/gpu/nova-core/regs/macros.rs
> @@ -116,7 +116,7 @@ macro_rules! register {
>      ) => {
>          register!(@common $name @ $offset $(, $comment)?);
>          register!(@field_accessors $name { $($fields)* });
> -        register!(@io$name @ + $offset);
> +        register!(@io $name @ + $offset);
>      };
>  
>      // Creates a alias register of relative offset register `alias` with its own fields.
> 
> -- 
> 2.50.1
> 
> 


More information about the dri-devel mailing list