[PATCH v5] rust: drm: Drop the use of Opaque for ioctl arguments

Daniel Almeida daniel.almeida at collabora.com
Mon Jul 21 15:42:12 UTC 2025



> On 26 Jun 2025, at 13:23, Beata Michalska <beata.michalska at arm.com> wrote:
> 
> With the Opaque<T>, the expectations are that Rust should not
> make any assumptions on the layout or invariants of the wrapped
> C types. That runs rather counter to ioctl arguments, which must
> adhere to certain data-layout constraints. By using Opaque<T>,
> ioctl handlers are forced to use unsafe code where none is actually
> needed. This adds needless complexity and maintenance overhead,
> brining no safety benefits.
> Drop the use of Opaque for ioctl arguments as that is not the best
> fit here.
> 
> Signed-off-by: Beata Michalska <beata.michalska at arm.com>
> Acked-by: Danilo Krummrich <dakr at kernel.org>
> Reviewed-by: Boqun Feng <boqun.feng at gmail.com>

Reviewed-by: Daniel Almeida <daniel.almeida at collabora.com> 



More information about the dri-devel mailing list