[PATCH] drm/bridge: Add null pointer check for ITE IT6263

[Biju Das]

Hi Chenyuan Yang,

Thanks for the patch.

> -----Original Message-----
> From: Chenyuan Yang <chenyuan0y at gmail.com>
> Sent: 22 July 2025 21:41
> Subject: [PATCH] drm/bridge: Add null pointer check for ITE IT6263
> 
> drm_atomic_get_new_connector_for_encoder and drm_atomic_get_new_connector_state could return Null.
> Thus, add the null pointer check for them with a similar format with it6505_bridge_atomic_enable in
> ITE IT6505.
> 
> Signed-off-by: Chenyuan Yang <chenyuan0y at gmail.com>
> Fixes: 049723628716 ("drm/bridge: Add ITE IT6263 LVDS to HDMI converter")

Normally Fixes should be above Sb tag.

> ---
>  drivers/gpu/drm/bridge/ite-it6263.c | 15 ++++++++++++++-
>  1 file changed, 14 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/bridge/ite-it6263.c b/drivers/gpu/drm/bridge/ite-it6263.c
> index a3a63a977b0a..3a20b2088bf9 100644
> --- a/drivers/gpu/drm/bridge/ite-it6263.c
> +++ b/drivers/gpu/drm/bridge/ite-it6263.c
> @@ -590,15 +590,28 @@ static void it6263_bridge_atomic_enable(struct drm_bridge *bridge,
>  	struct drm_connector *connector;
>  	bool is_stable = false;
>  	struct drm_crtc *crtc;
> +	struct drm_connector_state *conn_state;

Please arrange it in reverse X-mas tree fashion.

>  	unsigned int val;
>  	bool pclk_high;
>  	int i, ret;
> 
>  	connector = drm_atomic_get_new_connector_for_encoder(state,
>  							     bridge->encoder);
> -	crtc = drm_atomic_get_new_connector_state(state, connector)->crtc;
> +	if (WARN_ON(!connector))

Why WARN_ON everywhere? Can we use dev_err instead?

Cheers,
Biju

> +		return;
> +
> +	conn_state = drm_atomic_get_new_connector_state(state, connector);
> +	if (WARN_ON(!conn_state))
> +		return;
> +
> +	crtc = conn_state->crtc;
>  	crtc_state = drm_atomic_get_new_crtc_state(state, crtc);
> +	if (WARN_ON(!crtc_state))
> +		return;
> +
>  	mode = &crtc_state->adjusted_mode;
> +	if (WARN_ON(!mode))
> +		return;
> 
>  	regmap_write(regmap, HDMI_REG_HDMI_MODE, TX_HDMI_MODE);
> 
> --
> 2.34.1