[PATCH 2/4] drm/bridge: imx: add driver for HDMI TX Parallel Audio Interface

[Shengjiu Wang]

On Tue, Jul 22, 2025 at 3:50 PM Liu Ying <victor.liu at nxp.com> wrote:
>
> Hi Shengjiu,
>
> On 07/21/2025, Shengjiu Wang wrote:
> > On Fri, Jul 18, 2025 at 7:51 PM Alexander Stein
> > <alexander.stein at ew.tq-group.com> wrote:
>
> [...]
>
> >> Am Freitag, 18. Juli 2025, 12:11:48 CEST schrieb Shengjiu Wang:
>
> [...]
>
> >>> +     /* IEC60958 format */
> >>> +     val = 31 << FIELD_CTRL_P_SEL_SHIFT;
> >>> +     val |= 30 << FIELD_CTRL_C_SEL_SHIFT;
> >>> +     val |= 29 << FIELD_CTRL_U_SEL_SHIFT;
> >>> +     val |= 28 << FIELD_CTRL_V_SEL_SHIFT;
> >>> +     val |= 4 << FIELD_CTRL_D_SEL_SHIFT;
> >>> +     val |= 0 << FIELD_CTRL_PRE_SEL_SHIFT;
>
> [...]
>
> >> But where do these numbers come from? I can see that downstream kernel
> >> sets these bits depending on audio config being passed.
> >
> > These numbers are defined in standard IEC958 spec.
>
> Can these be defined by macros, even in a certain common header file,
> include/sound/asoundef.h?

yes, then will include ALSA maintainer for the change.

>
> --
> Regards,
> Liu Ying