[PATCH v4 05/17] phy: cdns-dphy: Remove leftover code

Tomi Valkeinen tomi.valkeinen at ideasonboard.com
Wed Jul 23 08:49:29 UTC 2025


Hi Vinod,

(I accidentally sent my mail only to you. List added here).

On 23/07/2025 10:36, Tomi Valkeinen wrote:
> Hi Vinod,
> 
> On 27/06/2025 02:32, Vinod Koul wrote:
>> On 18-06-25, 12:59, Tomi Valkeinen wrote:
>>> The code in cdns-dphy has probably been part of a DSI driver in the
>>> past. Remove DSI defines and variables which are not used or do not
>>> actually do anything. Also rename cdns_dsi_get_dphy_pll_cfg() to
>>> cdns_dphy_get_pll_cfg(), i.e. drop the "dsi", as it's not relevant here.
>>
>> Acked-by: Vinod Koul <vkoul at kernel.org>
>>
> 
> Are you fine merging the two cdns-dphy patches (this and 4/17) via drm
> tree? I think that's the easiest way to merge this.
> 
> I could also drop the 5/17 patch from the series, as it's just a
> cleanup, and it could be merged at some later point via phy tree.

Actually, I take that back. Devarsh also has some cdns-dphy patches,
which depend on my patches. It could get messy.

There's no compile-time dependency, and my DRM series doesn't depend on
the dphy changes even at runtime. I think it's best if I drop the dphy
changes from my series and send them separately.

 Tomi



More information about the dri-devel mailing list