[PATCH 02/10] PCI/P2PDMA: Introduce p2pdma_provider structure for cleaner abstraction
Leon Romanovsky
leon at kernel.org
Thu Jul 24 08:07:47 UTC 2025
On Thu, Jul 24, 2025 at 09:59:22AM +0200, Christoph Hellwig wrote:
> On Thu, Jul 24, 2025 at 10:55:33AM +0300, Leon Romanovsky wrote:
> > Please, see last patch in the series https://lore.kernel.org/all/aea452cc27ca9e5169f7279d7b524190c39e7260.1753274085.git.leonro@nvidia.com
> > It gives me a way to call p2p code with stable pointer for whole BAR.
> >
>
> That simply can't work. So I guess you're trying to do the same stupid
> things shut down before again? I might as well not waste my time
> reviewing this.
I'm not aware of anything that is not acceptable in this series.
This series focused on replacing dma_map_resource() call from v3
https://lore.kernel.org/all/20250307052248.405803-4-vivek.kasireddy@intel.com/
to proper API.
92 if (!state) {
93 addr = pci_p2pdma_bus_addr_map(provider, phys_vec->paddr);
94 } else if (dma_use_iova(state)) {
95 ret = dma_iova_link(attachment->dev, state, phys_vec->paddr, 0,
96 phys_vec->len, dir, DMA_ATTR_SKIP_CPU_SYNC);
97 if (ret)
98 goto err_free_table;
99
100 ret = dma_iova_sync(attachment->dev, state, 0, phys_vec->len);
101 if (ret)
102 goto err_unmap_dma;
103
104 addr = state->addr;
105 } else {
106 addr = dma_map_phys(attachment->dev, phys_vec->paddr,
107 phys_vec->len, dir, DMA_ATTR_SKIP_CPU_SYNC);
108 ret = dma_mapping_error(attachment->dev, addr);
109 if (ret)
110 goto err_free_table;
111 }
Thanks
>
>
More information about the dri-devel
mailing list