[PATCH] mm: Fix compile error when CONFIG_SHMEM is not set
Thomas Hellström
thomas.hellstrom at linux.intel.com
Wed Jun 4 12:18:06 UTC 2025
On Wed, 2025-06-04 at 08:04 -0400, Steven Rostedt wrote:
> On Wed, 4 Jun 2025 00:03:18 -0700 (PDT)
> Hugh Dickins <hughd at google.com> wrote:
>
> > I vote for the "select SHMEM", but Thomas and dri-devel and Linus
> > should decide.
>
> I only tried "depends on SHMEM" which did not work, but it looks like
> "select SHMEM" should.
I agree. The whole ttm_backup implementation is based on backing things
up to shmem objects so IMO it perfectly makes sense to "select SHMEM".
Let me know if you want me to send a patch for that.
In the very unlikely case someone would ever want a config without
SHMEM but with TTM, they'd have to live without the ttm_backup and we'd
create a separate config for that.
/Thomas
>
> I prefer this solution too.
>
> Thanks,
>
> -- Steve
More information about the dri-devel
mailing list