[PATCH 3/3] drm/amdgpu: Allow kfd CRIU with no buffer objects

[Yat Sin, David]

[AMD Official Use Only - AMD Internal Distribution Only]

> -----Original Message-----
> From: Francis, David <David.Francis at amd.com>
> Sent: Wednesday, May 21, 2025 10:07 AM
> To: dri-devel at lists.freedesktop.org
> Cc: tvrtko.ursulin at igalia.com; Kuehling, Felix <Felix.Kuehling at amd.com>; Yat Sin,
> David <David.YatSin at amd.com>; Freehill, Chris <Chris.Freehill at amd.com>;
> Koenig, Christian <Christian.Koenig at amd.com>; dcostantino at meta.com;
> sruffell at meta.com; simona at ffwll.ch; mripard at kernel.org; tzimmermann at suse.de;
> Francis, David <David.Francis at amd.com>
> Subject: [PATCH 3/3] drm/amdgpu: Allow kfd CRIU with no buffer objects
>
> The kfd CRIU checkpoint ioctl would return an error if trying to checkpoint a
> process with no kfd buffer objects.
>
> This is a normal case and should not be an error.
>
> Signed-off-by: David Francis <David.Francis at amd.com>
> ---
>  drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> index a8cf2d4580cc..7aa34bd15958 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> @@ -2570,7 +2570,7 @@ static int criu_restore(struct file *filep,
>                args->num_devices, args->num_bos, args->num_objects, args-
> >priv_data_size);
>
>       if (!args->bos || !args->devices || !args->priv_data || !args->priv_data_size ||
> -         !args->num_devices || !args->num_bos)
> +         !args->num_devices)
>               return -EINVAL;
>
Nit pick: The if statement should also allow args->bos to be NULL.

Regards
David Yat Sin


>       mutex_lock(&p->mutex);
> --
> 2.34.1