[PATCH v3 1/2] gpu/trace: make TRACE_GPU_MEM configurable

[Juston Li]

On Mon, 2025-06-09 at 13:36 +0100, Tvrtko Ursulin wrote:
> 
> On 03/06/2025 23:50, Juston Li wrote:
> > v3:
> >   - Patch introduced to replace per-driver config (Lucas)
> > 
> > Signed-off-by: Juston Li <justonli at chromium.org>
> > ---
> >   drivers/gpu/trace/Kconfig | 11 ++++++++++-
> >   1 file changed, 10 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/trace/Kconfig b/drivers/gpu/trace/Kconfig
> > index c24e9edd022e6..cd3d19c4a201c 100644
> > --- a/drivers/gpu/trace/Kconfig
> > +++ b/drivers/gpu/trace/Kconfig
> > @@ -1,4 +1,13 @@
> >   # SPDX-License-Identifier: GPL-2.0-only
> >   
> >   config TRACE_GPU_MEM
> > -	bool
> > +	bool "Enable GPU memory usage tracepoints"
> > +	default n
> > +	help
> > +	  Choose this option to enable tracepoints for tracking
> > +	  global and per-process GPU memory usage. Intended for
> > +	  performance profiling and required for Android.
> > +
> > +	  Tracepoint availability varies by GPU driver.
> > +
> > +	  If in doubt, say "N".
> 
> Maybe it is a bit sub-optimal that the item shows up under the top
> level 
> drivers group. Which is already pretty busy. Maybe on top something
> like:
> 
> diff --git a/drivers/Kconfig b/drivers/Kconfig
> index 7c556c5ac4fd..c5edbd2288a1 100644
> --- a/drivers/Kconfig
> +++ b/drivers/Kconfig
> @@ -209,8 +209,6 @@ source "drivers/thunderbolt/Kconfig"
> 
>   source "drivers/android/Kconfig"
> 
> -source "drivers/gpu/trace/Kconfig"
> -
>   source "drivers/nvdimm/Kconfig"
> 
>   source "drivers/dax/Kconfig"
> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
> index 5df981920a94..96adceab2df0 100644
> --- a/drivers/video/Kconfig
> +++ b/drivers/video/Kconfig
> @@ -70,5 +70,6 @@ if FB_CORE || SGI_NEWPORT_CONSOLE
> 
>   endif
> 
> +source "drivers/gpu/trace/Kconfig"
> 
>   endmenu
> 
> 
> To move it under Device Drivers -> Graphics support? Give or take the
> exact positioning.

SGTM, thanks!

Juston

> Regards,
> 
> Tvrtko