[PATCH v2 04/10] drm/xe/xe_late_bind_fw: Initialize late binding firmware

[Nilawar, Badal]

On 12-06-2025 16:05, Nilawar, Badal wrote:
>>> +static int late_bind_fw_init(struct xe_late_bind *late_bind, u32 type)
>>> +{
>>> +    struct xe_device *xe = late_bind_to_xe(late_bind);
>>> +    struct pci_dev *pdev = to_pci_dev(xe->drm.dev);
>>> +    struct xe_late_bind_fw *lb_fw;
>>> +    const struct firmware *fw;
>>> +    u32 num_fans;
>>> +    int ret;
>>> +
>>> +    if (!late_bind->component_added)
>>> +        return 0;
>>> +
>>> +    lb_fw = &late_bind->late_bind_fw;
>>> +
>>> +    lb_fw->type = type;
>>
>> Should we validate that "type" is sane?
> You mean if type is not max supported type. Sure, I will add.
IMO we don't need to validate type, CSC will return -4 i.e. invalid 
parameter error.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20250612/0bb6a540/attachment.htm>