[PATCH 08/12] drm/bridge: samsung-dsim: allow configuring the PLL_STABLE bit
Kaustabh Chakraborty
kauschluss at disroot.org
Thu Jun 12 15:18:12 UTC 2025
The PLL_STABLE bit of DSIM_DPHY_STATUS is hardcoded to BIT(31), but
Exynos7870's DSIM has it in BIT(24) as per downstream kernel sources.
In order to support both, move this bit value to the driver data struct
and define it for every driver compatible. Reference the value from
there instead, in functions wherever required.
Signed-off-by: Kaustabh Chakraborty <kauschluss at disroot.org>
---
drivers/gpu/drm/bridge/samsung-dsim.c | 9 +++++++--
include/drm/bridge/samsung-dsim.h | 1 +
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c
index fa7d21b08097dac09f90941200580af509924bdb..5787746c63035a94c0b8b7497df61bb1e69656cd 100644
--- a/drivers/gpu/drm/bridge/samsung-dsim.c
+++ b/drivers/gpu/drm/bridge/samsung-dsim.c
@@ -33,7 +33,6 @@
#define DSIM_STOP_STATE_DAT(x) (((x) & 0xf) << 0)
#define DSIM_STOP_STATE_CLK BIT(8)
#define DSIM_TX_READY_HS_CLK BIT(10)
-#define DSIM_PLL_STABLE BIT(31)
/* DSIM_SWRST */
#define DSIM_FUNCRST BIT(16)
@@ -413,6 +412,7 @@ static const struct samsung_dsim_driver_data exynos3_dsi_driver_data = {
.wait_for_reset = 1,
.num_bits_resol = 11,
.video_mode_bit = 25,
+ .pll_stable_bit = 31,
.esc_clken_bit = 28,
.byte_clken_bit = 24,
.tx_req_hsclk_bit = 31,
@@ -442,6 +442,7 @@ static const struct samsung_dsim_driver_data exynos4_dsi_driver_data = {
.wait_for_reset = 1,
.num_bits_resol = 11,
.video_mode_bit = 25,
+ .pll_stable_bit = 31,
.esc_clken_bit = 28,
.byte_clken_bit = 24,
.tx_req_hsclk_bit = 31,
@@ -469,6 +470,7 @@ static const struct samsung_dsim_driver_data exynos5_dsi_driver_data = {
.wait_for_reset = 1,
.num_bits_resol = 11,
.video_mode_bit = 25,
+ .pll_stable_bit = 31,
.esc_clken_bit = 28,
.byte_clken_bit = 24,
.tx_req_hsclk_bit = 31,
@@ -496,6 +498,7 @@ static const struct samsung_dsim_driver_data exynos5433_dsi_driver_data = {
.wait_for_reset = 0,
.num_bits_resol = 12,
.video_mode_bit = 25,
+ .pll_stable_bit = 31,
.esc_clken_bit = 28,
.byte_clken_bit = 24,
.tx_req_hsclk_bit = 31,
@@ -523,6 +526,7 @@ static const struct samsung_dsim_driver_data exynos5422_dsi_driver_data = {
.wait_for_reset = 1,
.num_bits_resol = 12,
.video_mode_bit = 25,
+ .pll_stable_bit = 31,
.esc_clken_bit = 28,
.byte_clken_bit = 24,
.tx_req_hsclk_bit = 31,
@@ -550,6 +554,7 @@ static const struct samsung_dsim_driver_data imx8mm_dsi_driver_data = {
.wait_for_reset = 0,
.num_bits_resol = 12,
.video_mode_bit = 25,
+ .pll_stable_bit = 31,
.esc_clken_bit = 28,
.byte_clken_bit = 24,
.tx_req_hsclk_bit = 31,
@@ -753,7 +758,7 @@ static unsigned long samsung_dsim_set_pll(struct samsung_dsim *dsi,
return 0;
}
reg = samsung_dsim_read(dsi, DSIM_LINK_STATUS_REG);
- } while ((reg & DSIM_PLL_STABLE) == 0);
+ } while ((reg & BIT(driver_data->pll_stable_bit)) == 0);
dsi->hs_clock = fout;
diff --git a/include/drm/bridge/samsung-dsim.h b/include/drm/bridge/samsung-dsim.h
index def9b4c6ef28eede8175aaa84c495c5444d0f103..2dd63032d83ab5df0e1780a692789c340c2126dc 100644
--- a/include/drm/bridge/samsung-dsim.h
+++ b/include/drm/bridge/samsung-dsim.h
@@ -64,6 +64,7 @@ struct samsung_dsim_driver_data {
unsigned int wait_for_reset;
unsigned int num_bits_resol;
unsigned int video_mode_bit;
+ unsigned int pll_stable_bit;
unsigned int esc_clken_bit;
unsigned int byte_clken_bit;
unsigned int tx_req_hsclk_bit;
--
2.49.0
More information about the dri-devel
mailing list