[PATCH v2 0/5] drm/xe: enable driver usage on non-4KiB kernels

Fri Jun 13 00:13:10 UTC 2025

For some reason this patch series didn't make it to any mailing
list... it only shows the b4-sent and stable:
https://lore.kernel.org/intel-xe/20250604-upstream-xe-non-4k-v2-v2-0-ce7905da7b08@aosc.io/

Could you resend this series?

thanks
Lucas De Marchi

On Wed, Jun 04, 2025 at 10:57:54AM +0800, Mingcong Bai via B4 Relay wrote:
>This patch series attempts to enable the use of xe DRM driver on non-4KiB
>kernel page platforms. This involves fixing the ttm/bo interface, as well
>as parts of the userspace API to make use of kernel `PAGE_SIZE' for
>alignment instead of the assumed `SZ_4K', it also fixes incorrect usage of
>`PAGE_SIZE' in the GuC and ring buffer interface code to make sure all
>instructions/commands were aligned to 4KiB barriers (per the Programmer's
>Manual for the GPUs covered by this DRM driver).
>
>This issue was first discovered and reported by members of the LoongArch
>user communities, whose hardware commonly ran on 16KiB-page kernels. The
>patch series began on an unassuming branch of a downstream kernel tree
>maintained by Shang Yatsen.[^1]
>
>It worked well but remained sparsely documented, a lot of the work done
>here relied on Shang Yatsen's original patch.
>
>AOSC OS then picked it up[^2] to provide Intel Xe/Arc support for users of
>its LoongArch port, for which I worked extensively on. After months of
>positive user feedback and from encouragement from Kexy Biscuit, my
>colleague at the community, I decided to examine its potential for
>upstreaming, cross-reference kernel and Intel documentation to better
>document and revise this patch.
>
>Now that this series has been tested good (for boot up, OpenGL, and
>playback of a standardised set of video samples[^3] on the following
>platforms (motherboard + GPU model):
>
>- x86-64, 4KiB kernel page:
>    - MS-7D42 + Intel Arc A580
>    - COLORFIRE B760M-MEOW WIFI D5 + Intel Arc B580
>- LoongArch, 16KiB kernel page:
>    - XA61200 + GUNNIR DG1 Blue Halberd (Intel DG1)
>    - XA61200 + GUNNIR Iris Xe Index 4 (Intel DG1)
>    - XA61200 + GUNNIR Intel Iris Xe Max Index V2 (Intel DG1)
>    - XA61200 + GUNNIR Intel Arc A380 Index 6G (Intel Arc A380)
>    - XA61200 + ASRock Arc A380 Challenger ITX OC (Intel Arc A380)
>    - XA61200 + Intel Arc A580
>    - XA61200 + GUNNIR Intel Arc A750 Photon 8G OC (Intel Arc A750)
>    - XA61200 + Intel Arc B580
>    - XB612B0 + GUNNIR Intel Iris Xe Max Index V2 (Intel DG1)
>    - XB612B0 + GUNNIR Intel Arc A380 Index 6G (Intel Arc A380)
>    - ASUS XC-LS3A6M + GUNNIR Intel Arc B580 INDEX 12G (Intel Arc B580)
>
>On these platforms, basic functionalities tested good but the driver was
>unstable with occasional resets (I do suspect however, that this platform
>suffers from PCIe coherence issues, as instability only occurs under heavy
>VRAM I/O load):
>
>- AArch64, 4KiB/64KiB kernel pages:
>    - ERUN-FD3000 (Phytium D3000) + GUNNIR Intel Iris Xe Max Index V2
>      (Intel DG1)
>    - ERUN-FD3000 (Phytium D3000) + GUNNIR Intel Arc A380 Index 6G
>      (Intel Arc A380)
>    - ERUN-FD3000 (Phytium D3000) + GUNNIR Intel Arc A750 Photon 8G OC
>      (Intel Arc A750)
>
>I think that this patch series is now ready for your comment and review.
>Please forgive me if I made any simple mistake or used wrong terminologies,
>but I have never worked on a patch for the DRM subsystem and my experience
>is still quite thin.
>
>But anyway, just letting you all know that Intel Xe/Arc works on non-4KiB
>kernel page platforms (and honestly, it's great to use, especially for
>games and media playback)!
>
>[^1]: https://github.com/FanFansfan/loongson-linux/tree/loongarch-xe
>[^2]: We maintained Shang Yatsen's patch until our v6.13.3 tree, until
>      we decided to test and send this series upstream,
>      https://github.com/AOSC-Tracking/linux/tree/aosc/v6.13.3
>[^3]: Delicious hot pot!
>      https://repo.aosc.io/ahvl/sample-videos-20250223.tar.zst
>
>---
>Matthew(s), Lucas, and Francois:
>
>Thanks again for your patience and review.
>
>I recently had a job change and it put me off this series for months, but
>I'm back (and should be a lot more responsive now) - sorry! Let's get this
>ball rolling again.
>
>I was unfortunately unable to revise 1/5 from v1 as you requested, neither
>of your suggestions to allow allocation of VRAM smaller than page size
>worked... So I kept that part as is.
>
>As for the your comment in 5/5, I'm not sure about what the right approach
>to implement a SZ_64K >= PAGE_SIZE assert was, as there are many other
>instances of similar ternary conditional operators in the xe code. Correct
>me if I'm wrong but I felt that it might be better handled in a separate
>patch series?
>
>---
>Changes in v2:
>
>- Define `GUC_ALIGN' and use them in GuC code to improve clarity.
>- Update documentation on `DRM_XE_QUERY_CONFIG_MIN_ALIGNMENT'.
>- Rebase, and other minor changes.
>- Link to v1:
>  https://lore.kernel.org/all/20250226-xe-non-4k-fix-v1-0-80f23b5ee40e@aosc.io/
>
>To: Lucas De Marchi <lucas.demarchi at intel.com>
>To: Thomas Hellström <thomas.hellstrom at linux.intel.com>
>To: Rodrigo Vivi <rodrigo.vivi at intel.com>
>To: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
>To: Maxime Ripard <mripard at kernel.org>
>To: Thomas Zimmermann <tzimmermann at suse.de>
>To: David Airlie <airlied at gmail.com>
>To: Simona Vetter <simona at ffwll.ch>
>To: José Roberto de Souza <jose.souza at intel.com>
>To: Francois Dugast <francois.dugast at intel.com>
>To: Matthew Brost <matthew.brost at intel.com>
>To: Alan Previn <alan.previn.teres.alexis at intel.com>
>To: Zhanjun Dong <zhanjun.dong at intel.com>
>To: Matt Roper <matthew.d.roper at intel.com>
>To: Mateusz Naklicki <mateusz.naklicki at intel.com>
>Cc: Mauro Carvalho Chehab <mauro.chehab at linux.intel.com>
>Cc: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
>Cc: intel-xe at lists.freedesktop.org
>Cc: dri-devel at lists.freedesktop.org
>Cc: linux-kernel at vger.kernel.org
>Suggested-by: Kexy Biscuit <kexybiscuit at aosc.io>
>Co-developed-by: Shang Yatsen <429839446 at qq.com>
>Signed-off-by: Shang Yatsen <429839446 at qq.com>
>Signed-off-by: Mingcong Bai <jeffbai at aosc.io>
>
>---
>Mingcong Bai (5):
>      drm/xe/bo: fix alignment with non-4KiB kernel page sizes
>      drm/xe/guc: use GUC_SIZE (SZ_4K) for alignment
>      drm/xe/regs: fix RING_CTL_SIZE(size) calculation
>      drm/xe: use 4KiB alignment for cursor jumps
>      drm/xe/query: use PAGE_SIZE as the minimum page alignment
>
> drivers/gpu/drm/xe/regs/xe_engine_regs.h |  2 +-
> drivers/gpu/drm/xe/xe_bo.c               |  8 ++++----
> drivers/gpu/drm/xe/xe_guc.c              |  4 ++--
> drivers/gpu/drm/xe/xe_guc.h              |  3 +++
> drivers/gpu/drm/xe/xe_guc_ads.c          | 32 ++++++++++++++++----------------
> drivers/gpu/drm/xe/xe_guc_capture.c      |  8 ++++----
> drivers/gpu/drm/xe/xe_guc_ct.c           |  2 +-
> drivers/gpu/drm/xe/xe_guc_log.c          |  5 +++--
> drivers/gpu/drm/xe/xe_guc_pc.c           |  4 ++--
> drivers/gpu/drm/xe/xe_migrate.c          |  4 ++--
> drivers/gpu/drm/xe/xe_query.c            |  2 +-
> include/uapi/drm/xe_drm.h                |  7 +++++--
> 12 files changed, 44 insertions(+), 37 deletions(-)
>---
>base-commit: 546b1c9e93c2bb8cf5ed24e0be1c86bb089b3253
>change-id: 20250603-upstream-xe-non-4k-v2-4acf253c9bfd
>
>Best regards,
>-- 
>Mingcong Bai <jeffbai at aosc.io>
>
>