[PATCH] drm/msm: Fix inverted WARN_ON() logic
Rob Clark
rob.clark at oss.qualcomm.com
Sat Jun 14 15:15:39 UTC 2025
On Fri, Jun 13, 2025 at 12:33 PM Konrad Dybcio
<konrad.dybcio at oss.qualcomm.com> wrote:
>
> On 6/13/25 4:57 PM, Alexey Klimov wrote:
> > On Fri Jun 13, 2025 at 3:41 PM BST, Rob Clark wrote:
> >> We want to WARN_ON() if info is NULL.
> >>
> >> Suggested-by: Konrad Dybcio <konrad.dybcio at oss.qualcomm.com>
> >> Fixes: 0838fc3e6718 ("drm/msm/adreno: Check for recognized GPU before bind")
> >> Tested-by: Neil Armstrong <neil.armstrong at linaro.org>
> >> Signed-off-by: Rob Clark <robin.clark at oss.qualcomm.com>
> >> ---
> >> drivers/gpu/drm/msm/adreno/adreno_device.c | 2 +-
> >
> > Apart from tag problem it is usually a good idea to add relevant people in
> > c/c. Especially when you fix the reported bug.
>
> with Alexey's concerns addressed:
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio at oss.qualcomm.com>
Oops, forgot the reported-by.. but replying with the tag on list is
enough, it will be picked up when I apply the patch
BR,
-R
More information about the dri-devel
mailing list