[PATCH v4 1/3] drm/bridge: microchip-lvds: drop unused drm_panel

Laurent Pinchart laurent.pinchart at ideasonboard.com
Tue Jun 24 10:42:48 UTC 2025


On Tue, Jun 24, 2025 at 02:54:14PM +0530, Dharma Balasubiramani wrote:
> Drop the drm_panel field of the mchp_lvds struct as it is unused.
> 
> Signed-off-by: Dharma Balasubiramani <dharma.b at microchip.com>
> ---
>  drivers/gpu/drm/bridge/microchip-lvds.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/microchip-lvds.c b/drivers/gpu/drm/bridge/microchip-lvds.c
> index 9f4ff82bc6b4..42751124b868 100644
> --- a/drivers/gpu/drm/bridge/microchip-lvds.c
> +++ b/drivers/gpu/drm/bridge/microchip-lvds.c
> @@ -23,7 +23,6 @@
>  #include <drm/drm_atomic_helper.h>
>  #include <drm/drm_bridge.h>
>  #include <drm/drm_of.h>
> -#include <drm/drm_panel.h>
>  #include <drm/drm_print.h>
>  #include <drm/drm_probe_helper.h>
>  #include <drm/drm_simple_kms_helper.h>
> @@ -56,7 +55,6 @@ struct mchp_lvds {
>  	struct device *dev;
>  	void __iomem *regs;
>  	struct clk *pclk;
> -	struct drm_panel *panel;
>  	struct drm_bridge bridge;
>  	struct drm_bridge *panel_bridge;
>  };
> @@ -179,13 +177,8 @@ static int mchp_lvds_probe(struct platform_device *pdev)
>  			"can't find port point, please init lvds panel port!\n");
>  		return -ENODEV;
>  	}

The above code seems unneeded now, I think you can drop it too.

> -
> -	lvds->panel = of_drm_find_panel(port);
>  	of_node_put(port);
>  
> -	if (IS_ERR(lvds->panel))
> -		return -EPROBE_DEFER;
> -
>  	lvds->panel_bridge = devm_drm_of_get_bridge(dev, dev->of_node, 1, 0);
>  
>  	if (IS_ERR(lvds->panel_bridge))

-- 
Regards,

Laurent Pinchart


More information about the dri-devel mailing list