[PATCH v3] rust: drm: Drop the use of Opaque for ioctl arguments
Danilo Krummrich
dakr at kernel.org
Tue Jun 24 21:35:57 UTC 2025
On Tue, Jun 24, 2025 at 11:22:25PM +0200, Beata Michalska wrote:
> With the Opaque<T>, the expectations are that Rust should not
> make any assumptions on the layout or invariants of the wrapped
> C types. That runs rather counter to ioctl arguments, which must
> adhere to certain data-layout constraits. By using Opaque<T>,
> ioctl handlers are forced to use unsafe code where non is acually
s/non/none/
> needed. This adds needless complexity and maintenance overhead,
> brining no safety benefits.
> Drop the use of Opaque for ioctl arguments as that is not the best
> fit here.
>
> Signed-off-by: Beata Michalska <beata.michalska at arm.com>
> [ nova-drm changes: Danilo ]
> Signed-off-by: Danilo Krummrich <dakr at kernel.org>
It's your patch, it doesn't need my 'Signed-off-by:', but feel free to convert
it into:
Acked-by: Danilo Krummrich <dakr at kernel.org>
More information about the dri-devel
mailing list