[PATCH] Introduce Tyr
Daniel Almeida
daniel.almeida at collabora.com
Mon Jun 30 14:01:52 UTC 2025
Hi Rob,
> On 30 Jun 2025, at 10:52, Rob Herring <robh at kernel.org> wrote:
>
> On Sat, Jun 28, 2025 at 4:31 AM Miguel Ojeda
> <miguel.ojeda.sandonis at gmail.com> wrote:
>>
>> On Sat, Jun 28, 2025 at 2:13 AM Daniel Almeida
>> <daniel.almeida at collabora.com> wrote:
>>>
>>> Also, for some reason the Clippy lint did not save me this time.
>>
>> Hmm... it should -- I tried to build it and Clippy reports it. There
>> is also another warning too [1].
>>
>> I see the compiler reporting [2] too.
>>
>> By the way, do you need to depend on `CONFIG_REGULATOR`?
>
> No. Drivers rely on empty stubs for all the providers they need. It
> would be pretty unmaintainable to depend on all of them. You want
> enabling drivers for compile testing as easy as possible.
>
> Rob
Without CONFIG_REGULATOR, the regulator abstraction doesn't build, which in
turns makes Tyr not build. So Miguel has a point, at least until the
abstraction itself is changed.
If that is not the right behavior, as you seem to be pointing out, could you
please comment on the patch[0] itself? I can then send a new version addressing
this.
— Daniel
[0]: https://lore.kernel.org/rust-for-linux/20250627-topics-tyr-regulator-v6-0-1d015219b454@collabora.com/
More information about the dri-devel
mailing list