[PATCH RESEND] drm/msm/dpu: Delete a variable initialisation before a null pointer check in two functions
Dan Carpenter
dan.carpenter at linaro.org
Mon Mar 3 07:14:06 UTC 2025
On Mon, Mar 03, 2025 at 01:01:40AM +0200, Dmitry Baryshkov wrote:
> On Sun, Mar 02, 2025 at 09:56:00PM +0100, Markus Elfring wrote:
> > From: Markus Elfring <elfring at users.sourceforge.net>
> > Date: Tue, 11 Apr 2023 18:24:24 +0200
> >
> > The address of a data structure member was determined before
> > a corresponding null pointer check in the implementation of
> > the functions “dpu_hw_pp_enable_te” and “dpu_hw_pp_get_vsync_info”.
> >
> > Thus avoid the risk for undefined behaviour by removing extra
> > initialisations for the variable “c” (also because it was already
> > reassigned with the same value behind this pointer check).
There is no undefined behavior here.
> >
> > This issue was detected by using the Coccinelle software.
>
> Please don't send resends and/or new iterations in response to your
> previous patchsets. Otherwise they have a pretty high chance to be
> ignored by the maintainers. Use a fresh git-send-email command to send
> new patchset.
>
> >
> > Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support")
Remove the Fixes tag. This patch is fine as a clean up.
> > Signed-off-by: Markus Elfring <elfring at users.sourceforge.net>
regards,
dan carpenter
More information about the dri-devel
mailing list