[PATCH 00/14] drm/panel: Transition away from using mipi_dsi_*_write_seq()

[Anusha Srivatsa]

On Sat, Feb 8, 2025 at 3:43 PM Doug Anderson <dianders at chromium.org> wrote:

> Hi,
>
> On Thu, Feb 6, 2025 at 1:06 PM Anusha Srivatsa <asrivats at redhat.com>
> wrote:
> >
> > Transition away from mipi_dsi_generic_write_seq() and
> > mipi_dsi_dcs_write_seq() to mipi_dsi_generic_write_seq_multi()
> > and mipi_dsi_dcs_write_seq_multi() respectively.
> >
> > This is addressing one of the gpu todo items [1]
> >
> > Used Coccinelle to make the code changes.
>
> As Dmitry mentioned [1], I think a real cleanup needs more thought
> than can be done in a Coccinelle script. Maybe you can make a script
> that's super fancy and does a perfect conversion, but I sorta doubt it
> in this case.
>
> A few other note:
>
> * Tejas Vipin has been slowly whittling down this TODO item. It would
> be good to CC him on any attempts to avoid duplicating work. He just
> submitted a patch [2] that duplicates one of the panels you ran your
> script on. It would also be good to look at the patches he has been
> posting to see some of the extra complexities.
>
> * I'm happy you CCed on the cover letter, but given that I've been
> helping with this TODO entry it would have been nice to have been CCed
> on all the patches.
>
> For now I'm not going to review the individual patches in this series.
> If there are any where you think your Coccinelle script really got
> everything adjusted perfectly then feel free to point them out and
> I'll review them. If you want to help with this effort, my own
> personal preference would be to at least start w/ one panel at a time
> since probably review feedback on all the conversions will be similar.
>
> Thanks!
>
>
I thought I had replied to this  :( (face-palm) sincere apologies. Luckily
I bumped into this today.  Thanks for the feedback. I agree with what you
said. While the script catches the patterns , a little of manual conversion
and proof checking is needed. I am taking this into account while I spin
the next version. WIll CC everyone in individual patches who have taken
their time to take a look at my clearly incomplete approach to this
redesign.

Again, thanks Dough

Anusha

> -Doug
>
> [1]
> https://lore.kernel.org/r/mz6usiheb2lx6wlk47z3btvf6t6kbo4ja4n6mli5hosrpcvdwp@wmvfvhaqhpkm
> [2]
> http://lore.kernel.org/r/20250208051541.176667-1-tejasvipin76@gmail.com
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20250305/cd9d0f50/attachment-0001.htm>