[PATCH] drm/appletbdrm: Fix ref-counting on dmadev

Aditya Garg gargaditya08 at live.com
Fri Mar 7 09:16:21 UTC 2025


Hi Thomas

> On 7 Mar 2025, at 2:06 PM, Thomas Zimmermann <tzimmermann at suse.de> wrote:
> 
> Remove the put_device() call on dmadev. The driver sets the field
> without getting a reference, so it shouldn't put a reference either.
> The dmadev field points to the regular USB device for which DRM
> maintains a reference internally. Hence dmadev will not become dangling
> during the DRM device's lifetime.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
> Fixes: 0670c2f56e45 ("drm/tiny: add driver for Apple Touch Bars in x86 Macs")
> Cc: Aditya Garg <gargaditya08 at live.com>
> Cc: Aun-Ali Zaidi <admin at kodeit.net>
> Cc: dri-devel at lists.freedesktop.org
> ---
> drivers/gpu/drm/tiny/appletbdrm.c | 1 -
> 1 file changed, 1 deletion(-)
> 

Aren’t we doing the same over here:

https://lore.kernel.org/dri-devel/20250307080836.42848-3-tzimmermann@suse.de/T/#u



More information about the dri-devel mailing list