[PATCH] fbdev: lcdcfb: Register sysfs groups through driver core
Helge Deller
deller at gmx.de
Sun Mar 9 02:00:35 UTC 2025
On 2/19/25 09:44, oushixiong1025 at 163.com wrote:
> From: Shixiong Ou <oushixiong at kylinos.cn>
>
> [WHY]
> 1. The driver forgot to call device_remove_file()
> in sh_mobile_lcdc_overlay_fb_unregister(), and there was
> no error handling when calling device_create_file() failed.
>
> 2. This should probably use device_add_group() instead of
> individual files to simplify both creation and removal. [Arnd]
>
> 3. The driver core can register and cleanup sysfs groups already.
> as commit 95cdd538e0e5 ("fbdev: efifb: Register sysfs groups
> through driver core").
>
> [HOW]
> Register sysfs groups through driver core.
>
> Signed-off-by: Shixiong Ou <oushixiong at kylinos.cn>
> ---
> drivers/video/fbdev/sh_mobile_lcdcfb.c | 29 ++++++++++++--------------
> 1 file changed, 13 insertions(+), 16 deletions(-)
applied.
Thanks!
Helge
More information about the dri-devel
mailing list