[PATCH v2 7/7] drm/ast: cursor: Drop page alignment

Jocelyn Falempe jfalempe at redhat.com
Tue Mar 11 13:10:30 UTC 2025


On 05/03/2025 17:30, Thomas Zimmermann wrote:
> The cursor scanout address requires alignment to a multiple of 8,
> but does not require page alignment. Change the offset calculation
> accordingly. Frees up a few more bytes for the primary framebuffer.
> 
The framebuffer is page aligned, so I'm not sure you can use the extra 
bytes.
Otherwise, it looks good to me.

Reviewed-by: Jocelyn Falempe <jfalempe at redhat.com>

> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
> ---
>   drivers/gpu/drm/ast/ast_cursor.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/ast/ast_cursor.c b/drivers/gpu/drm/ast/ast_cursor.c
> index cb0c48d47207..5ee724bfd682 100644
> --- a/drivers/gpu/drm/ast/ast_cursor.c
> +++ b/drivers/gpu/drm/ast/ast_cursor.c
> @@ -58,7 +58,7 @@ long ast_cursor_vram_offset(struct ast_device *ast)
>   	if (size > ast->vram_size)
>   		return -EINVAL;
>   
> -	return PAGE_ALIGN_DOWN(ast->vram_size - size);
> +	return ALIGN_DOWN(ast->vram_size - size, SZ_8);
>   }
>   
>   static u32 ast_cursor_calculate_checksum(const void *src, unsigned int width, unsigned int height)



More information about the dri-devel mailing list