[PATCH v3 5/7] dt-bindings: gpu: v3d: Add SMS register to BCM2712 compatible

[Maíra Canal]

Hi Krzysztof,

On 12/03/25 06:06, Krzysztof Kozlowski wrote:
> On Tue, Mar 11, 2025 at 07:05:31PM -0300, Maíra Canal wrote:
>>>> +        reg-names:
>>>> +          items:
>>>> +            - const: hub
>>>> +            - const: core0
>>>> +            - const: sms
>>>> +            - const: bridge
>>>
>>> This is an ABI change because previously the 3rd entry was bridge and
>>> you moved it. Put new entries on the end to keep compatibility. If
>>> there's no users yet, then that's fine, but the commit message needs to
>>> say that.
>>>
>>
>> Again, I'm sorry about the naive question, but "bridge" is an optional
>> register. AFAIU if I add "sms" in the end, I won't be able to make
>> "bridge" optional. Am I missing something?
> 
> What do you mean by "optional"? You claim the same SoC has this
> registers on some boards and also does not have it on others, so is
> firmware locking the region? How does this register disappear on some
> boards?

I believe I was confusing SoCs with the V3D GPU generations. I'm sorry
about that and I'll address this issue.

Thanks for your patience through this reviewing process!

Best Regards,
- Maíra

> 
>>
>> Initially, I thought about using "enum: [ bridge, sms ]", but from
>> Krzysztof’s feedback on v2, I'm not sure if it is the correct approach.
> 
> Best regards,
> Krzysztof
>