[PATCH RFT v2] drm/bridge: ite-it6505: make use of debugfs_init callback

Wolfram Sang wsa+renesas at sang-engineering.com
Sun Mar 16 06:26:07 UTC 2025


> > +	struct dentry *debugfs = debugfs_create_dir(dev_name(it6505->dev), root);

I will switch away from dev_name() here, too, of course.

> >  	int i = 0;
> >  
> >  	while (debugfs_entry[i].name && debugfs_entry[i].fops) {
> >  		debugfs_create_file(debugfs_entry[i].name, 0644,
> > -				    it6505->debugfs, it6505,
> > -				    debugfs_entry[i].fops);
> > +				    debugfs, it6505, debugfs_entry[i].fops);
> >  		i++;
> >  	}
> >  }
> 
> Ni: I'd say, it's better to move this function rather than moving
> it6505_bridge_funcs. LGTM otherwise.

I started like this but it meant to move all the sysfs file ops code as
well. That was quite a chunk. You still prefer to do it?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20250316/46e3bcdf/attachment.sig>


More information about the dri-devel mailing list