[PATCH] drm: Remove redundant statement in drm_crtc_helper_set_mode()

[Huacai Chen]

Hi, Dave,

Gentle ping, can this patch be merged into 6.15?

Huacai

On Mon, Jan 13, 2025 at 10:13 PM Huacai Chen <chenhuacai at kernel.org> wrote:
>
> Hi, Dave,
>
> Gentle ping, can this patch be merged into 6.14?
>
> Huacai
>
> On Mon, Nov 25, 2024 at 2:00 PM Huacai Chen <chenhuacai at kernel.org> wrote:
> >
> > On Mon, Nov 11, 2024 at 10:41 PM Jani Nikula
> > <jani.nikula at linux.intel.com> wrote:
> > >
> > > On Mon, 11 Nov 2024, Huacai Chen <chenhuacai at loongson.cn> wrote:
> > > > Commit dbbfaf5f2641a ("drm: Remove bridge support from legacy helpers")
> > > > removes the drm_bridge_mode_fixup() call in drm_crtc_helper_set_mode(),
> > > > which makes the subsequent "encoder_funcs = encoder->helper_private" be
> > > > redundant, so remove it.
> > > >
> > > > Cc: stable at vger.kernel.org
> > > > Fixes: dbbfaf5f2641a ("drm: Remove bridge support from legacy helpers")
> > >
> > > IMO not necessary because nothing's broken, it's just redundant.
> > Maintainer is free to keep or remove the Cc and Fixes tag. :)
> >
> > Huacai
> >
> > >
> > > Reviewed-by: Jani Nikula <jani.nikula at intel.com>
> > >
> > > > Signed-off-by: Huacai Chen <chenhuacai at loongson.cn>
> > > > ---
> > > >  drivers/gpu/drm/drm_crtc_helper.c | 1 -
> > > >  1 file changed, 1 deletion(-)
> > > >
> > > > diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c
> > > > index 0955f1c385dd..39497493f74c 100644
> > > > --- a/drivers/gpu/drm/drm_crtc_helper.c
> > > > +++ b/drivers/gpu/drm/drm_crtc_helper.c
> > > > @@ -334,7 +334,6 @@ bool drm_crtc_helper_set_mode(struct drm_crtc *crtc,
> > > >               if (!encoder_funcs)
> > > >                       continue;
> > > >
> > > > -             encoder_funcs = encoder->helper_private;
> > > >               if (encoder_funcs->mode_fixup) {
> > > >                       if (!(ret = encoder_funcs->mode_fixup(encoder, mode,
> > > >                                                             adjusted_mode))) {
> > >
> > > --
> > > Jani Nikula, Intel