[PATCH v7 drm-dp 5/9] drm/hisilicon/hibmc: Getting connector info and EDID by using AUX channel

[Yongbang Shi]

在 2025/3/26 17:32, Jani Nikula 写道:
> On Tue, 25 Mar 2025, Yongbang Shi <shiyongbang at huawei.com> wrote:
>>> On Mon, 24 Mar 2025, Yongbang Shi <shiyongbang at huawei.com> wrote:
>>>>> On Wed, 19 Mar 2025, Yongbang Shi <shiyongbang at huawei.com> wrote:
>>>>>> From: Baihan Li <libaihan at huawei.com>
>>>>>>
>>>>>> Add registering drm_aux and use it to get connector edid with drm
>>>>>> functions. Add ddc channel in connector initialization to put drm_aux
>>>>>> in drm_connector.
>>>>>>
>>>>>> Signed-off-by: Baihan Li <libaihan at huawei.com>
>>>>>> Signed-off-by: Yongbang Shi <shiyongbang at huawei.com>
>>>>>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
>>>>>> ---
>>>>>> ChangeLog:
>>>>>> v6 -> v7:
>>>>>>      - add if statement about drm aux in hibmc_dp_connector_get_modes(), suggested by Jani Nikula
>>>>> I don't understand this, and I did not suggest such a thing.
>>>>>
>>>>> BR,
>>>>> Jani.
>>>>>
>>>> Hi Jani,
>>>>
>>>> Is the modification of v8 correct?
>>> I never received that for whatever reason.
>> Here's the link: https://lore.kernel.org/all/20250320101455.2538835-1-shiyongbang@huawei.com/
> Thanks.
>
> The EDID handling looks fine.
>
> AFAICT you leak dp->aux.name though.
>
>
> BR,
> Jani.

Thanks for for reminding me, actually the dp->aux.name was written because I misunderstood what you meant in V7,
and I deleted it in V8.

Thanks,
Baihan.

>
>