[PATCH v2 01/34] drm: convert many bridge drivers from devm_kzalloc() to devm_drm_bridge_alloc() API

[Manikandan.M at microchip.com]

On 30/04/25 4:06 pm, Luca Ceresoli wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Hello Manikandan,
> 
> On Wed, 30 Apr 2025 09:42:16 +0000
> <Manikandan.M at microchip.com> wrote:
> 
> [...]
> 
>>> diff --git a/drivers/gpu/drm/bridge/microchip-lvds.c b/drivers/gpu/drm/bridge/microchip-lvds.c
>>> index 1d4ae0097df847d9f93c79eecff0c4587ae331ba..9f4ff82bc6b49010f8727da3b367f5a744a28edc 100644
>>> --- a/drivers/gpu/drm/bridge/microchip-lvds.c
>>> +++ b/drivers/gpu/drm/bridge/microchip-lvds.c
>>> @@ -157,9 +157,10 @@ static int mchp_lvds_probe(struct platform_device *pdev)
>>>           if (!dev->of_node)
>>>                   return -ENODEV;
>>>
>>> -       lvds = devm_kzalloc(&pdev->dev, sizeof(*lvds), GFP_KERNEL);
>>> -       if (!lvds)
>>> -               return -ENOMEM;
>>> +       lvds = devm_drm_bridge_alloc(&pdev->dev, struct mchp_lvds, bridge,
>>> +                                    &mchp_lvds_bridge_funcs);
>>> +       if (IS_ERR(lvds))
>>> +               return PTR_ERR(lvds);
>>>
>>>           lvds->dev = dev;
>>>
>>> @@ -192,7 +193,6 @@ static int mchp_lvds_probe(struct platform_device *pdev)
>>>
>>>           lvds->bridge.of_node = dev->of_node;
>>>           lvds->bridge.type = DRM_MODE_CONNECTOR_LVDS;
>>> -       lvds->bridge.funcs = &mchp_lvds_bridge_funcs;
>>>
>>>           dev_set_drvdata(dev, lvds);
>>>           ret = devm_pm_runtime_enable(dev);
>>
>> Reviewed-by: Manikandan Muralidharan <manikandan.m at microchip.com>
> 
> Thanks for reviewing!
> 
> In v3 this patch will be slightly different from v2. See the reply I
> just sent to Doug for the details.
> 
> If your Reviewed-by tag refers only to the microchip-lvds driver, for
> which there will be no change in v3, I think it's correct to take your
> tag and add a comment like:
> 
>   Reviewed-by: Manikandan Muralidharan <manikandan.m at microchip.com> # microchip-lvds.c
> 
> Anything against this?
> 
No, Luca. Please proceed with the above mentioned tag # microchip-lvds.c
> Best regards,
> Luca
> 
> --
> Luca Ceresoli, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

-- 
Thanks and Regards,
Manikandan M.