[PATCH v8 10/14] dma-contiguous: export dma_contiguous_default_area

Jens Wiklander jens.wiklander at linaro.org
Mon May 5 10:00:12 UTC 2025


Hi,

On Fri, May 2, 2025 at 3:11 PM Robin Murphy <robin.murphy at arm.com> wrote:
>
> On 02/05/2025 10:59 am, Jens Wiklander wrote:
> > Export the global variable dma_contiguous_default_area so
> > dev_get_cma_area() can be called a module.
>
> What dma_map_ops implementation is in a module? Without any other
> context, I can't help thinking this smells of something sketchy.

I see that you found the rest of the patch set
https://lore.kernel.org/lkml/20250502100049.1746335-1-jens.wiklander@linaro.org/

Thanks,
Jens


>
> Thanks,
> Robin.
>
> > Cc: Marek Szyprowski <m.szyprowski at samsung.com>
> > Cc: Robin Murphy <robin.murphy at arm.com>
> > Cc: iommu at lists.linux.dev
> > Signed-off-by: Jens Wiklander <jens.wiklander at linaro.org>
> > ---
> >   kernel/dma/contiguous.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/kernel/dma/contiguous.c b/kernel/dma/contiguous.c
> > index 8df0dfaaca18..eb361794a9c5 100644
> > --- a/kernel/dma/contiguous.c
> > +++ b/kernel/dma/contiguous.c
> > @@ -53,6 +53,7 @@
> >   #endif
> >
> >   struct cma *dma_contiguous_default_area;
> > +EXPORT_SYMBOL(dma_contiguous_default_area);
> >
> >   /*
> >    * Default global CMA area size can be defined in kernel's .config.


More information about the dri-devel mailing list