[PATCH v2] drm/sched: fix the warning in drm_sched_job_done

[Philipp Stanner]

On Wed, 2025-05-07 at 06:27 +0000, Khatri, Sunil wrote:
> [AMD Official Use Only - AMD Internal Distribution Only]
> 
> Ping ?

Hello,

sry, I was out for a few days.

> 
> Not picked yet while patches raised before this are merged.
> 
> Regards
> Sunil Khatri
> 
> -----Original Message-----
> From: Koenig, Christian <Christian.Koenig at amd.com>
> Sent: Tuesday, April 29, 2025 12:49 PM
> To: Khatri, Sunil <Sunil.Khatri at amd.com>;
> dri-devel at lists.freedesktop.org; Danilo Krummrich <dakr at kernel.org>;
> Philipp Stanner <phasta at kernel.org>
> Cc: Deucher, Alexander <Alexander.Deucher at amd.com>; Tvrtko Ursulin
> <tvrtko.ursulin at igalia.com>; Pelloux-Prayer, Pierre-Eric
> <Pierre-eric.Pelloux-prayer at amd.com>
> Subject: Re: [PATCH v2] drm/sched: fix the warning in
> drm_sched_job_done

Call it "docu warning" please

> 
> Adding Danilo and Philipp.
> 
> Christian.
> 
> On 4/29/25 08:36, Khatri, Sunil wrote:
> > [AMD Official Use Only - AMD Internal Distribution Only]
> > 
> > Ping ?
> > 
> > -----Original Message-----
> > From: Sunil Khatri <sunil.khatri at amd.com>
> > Sent: Thursday, April 17, 2025 3:55 PM
> > To: dri-devel at lists.freedesktop.org; amd-gfx at lists.freedesktop.org
> > Cc: Deucher, Alexander <Alexander.Deucher at amd.com>; Koenig,
> > Christian <Christian.Koenig at amd.com>; Tvrtko Ursulin
> > <tvrtko.ursulin at igalia.com>; Pelloux-Prayer, Pierre-Eric
> > <Pierre-eric.Pelloux-prayer at amd.com>; Khatri, Sunil
> > <Sunil.Khatri at amd.com>
> > Subject: [PATCH v2] drm/sched: fix the warning in
> > drm_sched_job_done
> > 
> > Fix the below warning.
> > scheduler/sched_main.c:397: warning: Function parameter or struct
> > member 'result' not described in 'drm_sched_job_done'
> > 
> > Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at igalia.com>
> > Signed-off-by: Sunil Khatri <sunil.khatri at amd.com>
> > ---
> >  drivers/gpu/drm/scheduler/sched_main.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/gpu/drm/scheduler/sched_main.c
> > b/drivers/gpu/drm/scheduler/sched_main.c
> > index bfea608a7106..5cd29e92b133 100644
> > --- a/drivers/gpu/drm/scheduler/sched_main.c
> > +++ b/drivers/gpu/drm/scheduler/sched_main.c
> > @@ -390,6 +390,7 @@ static void drm_sched_run_free_queue(struct
> > drm_gpu_scheduler *sched)
> >  /**
> >   * drm_sched_job_done - complete a job
> >   * @s_job: pointer to the job which is done
> > + * @result: error code for dma fence for scheduler

s/dma fence/dma_fence


Besides, all good of course. Thank you.

P.

> >   *
> >   * Finish the job's fence and wake up the worker thread.
> >   */
> > --
> > 2.34.1
> > 
>