[PATCH v3 1/3] dt-bindings: display/msm/gmu: Add Adreno 623 GMU
Krzysztof Kozlowski
krzysztof.kozlowski at linaro.org
Fri May 9 05:42:31 UTC 2025
On 08/05/2025 18:19, Akhil P Oommen wrote:
> From: Jie Zhang <quic_jiezh at quicinc.com>
>
> Document Adreno 623 GMU in the dt-binding specification.
>
> Signed-off-by: Jie Zhang <quic_jiezh at quicinc.com>
> Signed-off-by: Akhil P Oommen <quic_akhilpo at quicinc.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
Drop. You changed patch significantly, like 90%!
> ---
> .../devicetree/bindings/display/msm/gmu.yaml | 34 ++++++++++++++++++++++
> 1 file changed, 34 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/gmu.yaml b/Documentation/devicetree/bindings/display/msm/gmu.yaml
> index 4392aa7a4ffe2492d69a21e067be1f42e00016d8..afc1879357440c137cadeb2d9a74ae8459570a25 100644
> --- a/Documentation/devicetree/bindings/display/msm/gmu.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/gmu.yaml
> @@ -124,6 +124,40 @@ allOf:
> contains:
> enum:
> - qcom,adreno-gmu-623.0
I don't understand. 623 is already here, you document nothing new. This
makes no sense, I never, absolutely never reviewed code like this.
NAK
Best regards,
Krzysztof
More information about the dri-devel
mailing list