[PATCH] accel/ivpu: Use firmware names from upstream repo

Jeff Hugo jeff.hugo at oss.qualcomm.com
Mon May 12 18:36:15 UTC 2025


On 5/7/2025 9:24 AM, Lizhi Hou wrote:
> 
> On 5/6/25 23:59, Jacek Lawrynowicz wrote:
>> Hi,
>>
>> On 5/6/2025 5:41 PM, Lizhi Hou wrote:
>>> On 5/6/25 02:20, Jacek Lawrynowicz wrote:
>>>> Use FW names from linux-firmware repo instead of deprecated ones.
>>>>
>>>> Fixes: c140244f0cfb ("accel/ivpu: Add initial Panther Lake support")
>>>> Cc: <stable at vger.kernel.org> # v6.13+
>>>> Signed-off-by: Jacek Lawrynowicz <jacek.lawrynowicz at linux.intel.com>
>>>> ---
>>>>    drivers/accel/ivpu/ivpu_fw.c | 12 ++++++------
>>>>    1 file changed, 6 insertions(+), 6 deletions(-)
>>>>
>>>> diff --git a/drivers/accel/ivpu/ivpu_fw.c b/drivers/accel/ivpu/ 
>>>> ivpu_fw.c
>>>> index ccaaf6c100c02..9db741695401e 100644
>>>> --- a/drivers/accel/ivpu/ivpu_fw.c
>>>> +++ b/drivers/accel/ivpu/ivpu_fw.c
>>>> @@ -55,18 +55,18 @@ static struct {
>>>>        int gen;
>>>>        const char *name;
>>>>    } fw_names[] = {
>>>> -    { IVPU_HW_IP_37XX, "vpu_37xx.bin" },
>>>> +    { IVPU_HW_IP_37XX, "intel/vpu/vpu_37xx_v1.bin" },
>>> What if old only vpu_37xx.bin is installed but not intel/vpu/ 
>>> vpu_37xx_v1?
>>>
>>> Maybe just put *_v1 line in front without removing { ..., 
>>> "vpu_37xx.bin"} ?
>>>
>> The vpu_37xx.bin style names were never released. This was only for 
>> developer convenience but it turns out that developers don't use this 
>> anymore, so it is safe to remove. Maybe it make sense to mention this 
>> in commit message :)
> 
> Sounds great.
> 
> Reviewed-by: Lizhi Hou <lizhi.hou at amd.com>

Reviewed-by: Jeff Hugo <jeff.hugo at oss.qualcomm.com>


More information about the dri-devel mailing list