[PATCH] drm/scheduler: signal scheduled fence when kill job

Christian König christian.koenig at amd.com
Thu May 15 08:48:13 UTC 2025


Explicitly adding the scheduler maintainers.

On 5/15/25 04:07, Lin.Cao wrote:
> Previously we only signaled finished fence which may cause some
> submission's dependency cannot be cleared the cause benchmark hang.
> Signal both scheduled fence and finished fence could fix this issue.
> 
> Signed-off-by: Lin.Cao <lincao12 at amd.com>

Reviewed-by: Christian König <christian.koenig at amd.com>

Danilo & Philipp can we quickly get an rb for that? I'm volunteering to push it to drm-misc-fixes and add the necessary stable tags since this is a fix for a rather ugly bug.

Regards,
Christian.


> ---
>  drivers/gpu/drm/scheduler/sched_entity.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/scheduler/sched_entity.c b/drivers/gpu/drm/scheduler/sched_entity.c
> index bd39db7bb240..e671aa241720 100644
> --- a/drivers/gpu/drm/scheduler/sched_entity.c
> +++ b/drivers/gpu/drm/scheduler/sched_entity.c
> @@ -176,6 +176,7 @@ static void drm_sched_entity_kill_jobs_work(struct work_struct *wrk)
>  {
>  	struct drm_sched_job *job = container_of(wrk, typeof(*job), work);
>  
> +	drm_sched_fence_scheduled(job->s_fence, NULL);
>  	drm_sched_fence_finished(job->s_fence, -ESRCH);
>  	WARN_ON(job->s_fence->parent);
>  	job->sched->ops->free_job(job);



More information about the dri-devel mailing list