[PATCH 04/45] drm/msm/dp: split msm_dp_panel_read_sink_caps() into two parts
Dmitry Baryshkov
dmitry.baryshkov at oss.qualcomm.com
Thu May 22 12:38:57 UTC 2025
On Thu, May 22, 2025 at 05:51:52PM +0800, Yongxing Mou wrote:
>
>
> On 2024/12/6 16:51, Dmitry Baryshkov wrote:
> > On Thu, Dec 05, 2024 at 08:31:35PM -0800, Abhinav Kumar wrote:
> > > In preparation of DP MST where link caps are read for the
> > > immediate downstream device and the edid is read through
> > > sideband messaging, split the msm_dp_panel_read_sink_caps() into
> > > two parts which read the link parameters and the edid parts
> > > respectively.
> >
> > As you are touching this part, could you please refactor the code
> > instead by dropping the msm_dp_panel->drm_edid? There should be no need
> > to store EDID in the panel structure.
> >
> Hi, Dmitry, Abhinav will be leaving the company and will no longer be
> responsible for updating and address the comments. I will take over handling
> MST patch series. Regarding this comments, I don't got that where the
> drm_edid should be stored. In MST cases, where multiple panels exist, i
> think that there should be a separate drm_edid saved for each panel.
Why do we need to store EDID at all?
--
With best wishes
Dmitry
More information about the dri-devel
mailing list