[PATCH v5 21/24] drm/msm/dpu: Implement 10-bit color alpha for v12.0 DPU
Krzysztof Kozlowski
krzysztof.kozlowski at linaro.org
Fri May 23 09:50:52 UTC 2025
On 23/05/2025 09:02, Abel Vesa wrote:
>>> static void _dpu_crtc_setup_blend_cfg(struct dpu_crtc_mixer *mixer,
>>> - struct dpu_plane_state *pstate, const struct msm_format *format)
>>> + struct dpu_plane_state *pstate,
>>> + const struct msm_format *format,
>>> + const struct dpu_mdss_version *mdss_ver)
>>> {
>>> struct dpu_hw_mixer *lm = mixer->hw_lm;
>>> uint32_t blend_op;
>>> - uint32_t fg_alpha, bg_alpha;
>>> + uint32_t fg_alpha, bg_alpha, max_alpha;
>>>
>>> fg_alpha = pstate->base.alpha >> 8;
>>
>> For the 10-bit alpha, you need to shift here by 5 instead of 8.
>
> Typo. "6 instead of 8".
>
Thanks, this indeed fixes the darkness!
Best regards,
Krzysztof
More information about the dri-devel
mailing list