[PATCH v10 06/10] drm/i915/nvm: add nvm device for discrete graphics

[Usyskin, Alexander]

> Subject: Re: [PATCH v10 06/10] drm/i915/nvm: add nvm device for discrete
> graphics
> 
> On Tue, May 27, 2025 at 11:30:20AM +0530, Usyskin, Alexander wrote:
> > > Subject: Re: [PATCH v10 06/10] drm/i915/nvm: add nvm device for discrete
> > > graphics
> > >
> > > On Thu, May 15, 2025 at 04:33:41PM +0300, Alexander Usyskin wrote:
> > > > Enable access to internal non-volatile memory on
> > > > DGFX devices via a child device.
> > > > The nvm child device is exposed via auxiliary bus.
> > >
> > > ...
> > >
> > > > +void intel_nvm_init(struct drm_i915_private *i915)
> > > > +{
> > >
> > > Lucas recently revamped xe driver to address this, so let's not hide bugs
> > > and return an error where possible.
> > >
> > I can return error from this call, but the SPI failure is non-fatal for Xe.
> > Caller should ignore error from this init.
> 
> Fair. Let's atleast return error and leave the handling to the caller,
> so we don't have to come back revamping it in the future.

Ok, will add return values here

> 
> Raag