<div dir="ltr"><div><div><div><div><span style="font-family:verdana,sans-serif">Hello Thierry,<br><br></span></div><span style="font-family:verdana,sans-serif">I am not agree here and how it would be redundant ? <br><br></span></div><span style="font-family:verdana,sans-serif">please see lvds interface, where panel timing parameter is defined in the Device Tree. If there are multiple display panel then we can create a separate dtsi file and include in main Board dts file. I believe that, It is simpler way to support multiple panel. <br><br><a href="http://git.freescale.com/git/cgit.cgi/imx/linux-2.6-imx.git/tree/arch/arm/boot/dts/imx6q-sabrelite.dts?h=imx_3.14.38_6qp_beta#n225">http://git.freescale.com/git/cgit.cgi/imx/linux-2.6-imx.git/tree/arch/arm/boot/dts/imx6q-sabrelite.dts?h=imx_3.14.38_6qp_beta#n225</a> <br><br></span></div><span style="font-family:verdana,sans-serif">Regards<br></span></div><span style="font-family:verdana,sans-serif">Sanjeev Sharma </span><br><div><div><div><div><div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Feb 22, 2016 at 5:13 PM, Thierry Reding <span dir="ltr"><<a href="mailto:thierry.reding@gmail.com" target="_blank">thierry.reding@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="">On Mon, Feb 22, 2016 at 04:42:54PM +0530, sanjeev sharma wrote:<br>
> Hello Jitao,<br>
><br>
> Can't we add this panel information in device tree file instead inside the<br>
> device driver ?<br>
<br>
</span>We could, but that would be redundant. Panels need to be represented by<br>
a specific compatible string anyway, and that compatible string implies<br>
the video timings, bits-per-color, width and height.<br>
<br>
Also there's more to panels than just the timings or dimensions. Power<br>
up and power down sequences are also implied by the compatible stirng.<br>
Describing all of that in the device tree was at some point attempted,<br>
but in the end it turned out too complicated and we ended up with what<br>
we have now.<br>
<span class=""><font color="#888888"><br>
Thierry<br>
</font></span><div class=""><div class="h5"><br>
> On Mon, Feb 22, 2016 at 4:31 PM, Jitao Shi <<a href="mailto:jitao.shi@mediatek.com">jitao.shi@mediatek.com</a>> wrote:<br>
><br>
> > The LG lp120up1 TFT LCD panel with eDP interface is a 12.0" 1920x1280<br>
> > panel, which can be supported by the simple panel driver<br>
> ><br>
> > Signed-off-by: Jitao Shi <<a href="mailto:jitao.shi@mediatek.com">jitao.shi@mediatek.com</a>><br>
> > ---<br>
> > Changes since v1:<br>
> > - Add eDP panel type in comment msg<br>
> > - Fixed comment msg with 72 characters width<br>
> > ---<br>
> > drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++<br>
> > 1 file changed, 26 insertions(+)<br>
> ><br>
> > diff --git a/drivers/gpu/drm/panel/panel-simple.c<br>
> > b/drivers/gpu/drm/panel/panel-simple.c<br>
> > index f88a631..2030c37 100644<br>
> > --- a/drivers/gpu/drm/panel/panel-simple.c<br>
> > +++ b/drivers/gpu/drm/panel/panel-simple.c<br>
> > @@ -982,6 +982,29 @@ static const struct panel_desc lg_lb070wv8 = {<br>
> > .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,<br>
> > };<br>
> ><br>
> > +static const struct drm_display_mode lg_lp120up1_mode = {<br>
> > + .clock = 162300,<br>
> > + .hdisplay = 1920,<br>
> > + .hsync_start = 1920 + 40,<br>
> > + .hsync_end = 1920 + 40 + 40,<br>
> > + .htotal = 1920 + 40 + 40+ 80,<br>
> > + .vdisplay = 1280,<br>
> > + .vsync_start = 1280 + 4,<br>
> > + .vsync_end = 1280 + 4 + 4,<br>
> > + .vtotal = 1280 + 4 + 4 + 12,<br>
> > + .vrefresh = 60,<br>
> > +};<br>
> > +<br>
> > +static const struct panel_desc lg_lp120up1 = {<br>
> > + .modes = &lg_lp120up1_mode,<br>
> > + .num_modes = 1,<br>
> > + .bpc = 8,<br>
> > + .size = {<br>
> > + .width = 267,<br>
> > + .height = 183,<br>
> > + },<br>
> > +};<br>
> > +<br>
> > static const struct drm_display_mode lg_lp129qe_mode = {<br>
> > .clock = 285250,<br>
> > .hdisplay = 2560,<br>
> > @@ -1256,6 +1279,9 @@ static const struct of_device_id platform_of_match[]<br>
> > = {<br>
> > .compatible = "lg,lb070wv8",<br>
> > .data = &lg_lb070wv8,<br>
> > }, {<br>
> > + .compatible = "lg,lp120up1",<br>
> > + .data = &lg_lp120up1,<br>
> > + }, {<br>
> > .compatible = "lg,lp129qe",<br>
> > .data = &lg_lp129qe,<br>
> > }, {<br>
> > --<br>
> > 1.7.9.5<br>
> ><br>
> ><br>
> > _______________________________________________<br>
> > linux-arm-kernel mailing list<br>
> > <a href="mailto:linux-arm-kernel@lists.infradead.org">linux-arm-kernel@lists.infradead.org</a><br>
> > <a href="http://lists.infradead.org/mailman/listinfo/linux-arm-kernel" rel="noreferrer" target="_blank">http://lists.infradead.org/mailman/listinfo/linux-arm-kernel</a><br>
> ><br>
</div></div></blockquote></div><br></div></div></div></div></div></div></div></div></div>