<html><head><style> p {margin-top:0px;margin-bottom:0px;} </style></head> <body><div style="font-size:12px; font-family:굴림,굴림체,Gulim,Baekmuk Dotum,Undotum,Apple Gothic,Latin font,sans-serif;"> <table border=0 width=100% style='margin 0 auto;background: ;' cellpadding=0 cellspacing=0> <tr> <td valign=top style='padding:8pt;'> <div class="tx-hanmail-content-wrapper" style="color: rgb(51, 51, 51); font-family: 돋움; font-size: 10pt; line-height: 1.5; background-color: transparent;"><blockquote style="font-size:12px;border-left-style:solid;border-left-width:2px;margin-bottom:0pt;margin-left:0.8ex;margin-right:0pt;margin-top:0pt;padding-left:1ex;"><div style="font-family:arial,돋움;line-height:20px"><div class="viewmail-textHtml" name="viewmail-textHtml" id="viewmail-textHtml"><br> Hmmm... But, in failure case, is it safe to call putback_lru_page() for them?<br> And, PageIsolated() would be left. Is it okay? It's not symmetric that<br> isolated page can be freed by decreasing ref count without calling<br> putback function. This should be clarified and documented.<br> <br><br></div></div></blockquote><style>p {font-size:10pt ! important;font-family:돋움,'굴림',gulim,tahoma,sans-serif ! important;}</style><p><br></p><p>I agree Joonsoo's idea.</p><p>Freeing isolated page out of putback() could be confused.</p><p>Every detail cannot be documented. And more documents mean less elegant code.</p><p>Is it possible to free isolated page in putback()?</p><p><br></p><p>In move_to_new_page(), can we call a_ops->migratepage like following?</p><p><br></p><p>move_to_new_page()</p><p>{</p><p>mapping = page_mapping(page)</p><p>if (!mapping)</p><p> rc = migrate_page</p><p>else if (mapping->a_ops->migratepage && IsolatePage(page))</p><p> rc = mapping->a_ops->migratepage</p><p>else</p><p> rc = fallback_migrate_page</p><p>...</p><p> return rc</p><p>}</p><p><br></p><p>I'm sorry that I couldn't review in detail because I forgot many details.</p><p><br></p></div></td></tr> </table> </div></body></html>  <br><br><a href="mailto:gurugio@hanmail.net"><img src="http://nametag.hanmail.net/Kk8NwEH1.I.q95.FfPs-qw00" border="0"></a>  <img src="http://wwl1662.hanmail.net:4280/@from=gurugio&rcpt=dri%2Ddevel%40lists%2Efreedesktop%2Eorg&msgid=%3C20160324052650%2EHM%2Ee0000000006t8Yn%40gurugio%2Ewwl1662%2Ehanmail%2Enet%3E">