<div dir="ltr">That did the trick thanks</div><br><div class="gmail_quote"><div dir="ltr">On Fri, 13 May 2016 at 22:36 Alex Deucher <<a href="mailto:alexdeucher@gmail.com">alexdeucher@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Eric Huang <<a href="mailto:JinHuiEric.Huang@amd.com" target="_blank">JinHuiEric.Huang@amd.com</a>><br>
<br>
Fixes OD failures on Tonga.<br>
<br>
Reviewed-by: Alex Deucher <<a href="mailto:alexander.deucher@amd.com" target="_blank">alexander.deucher@amd.com</a>><br>
Signed-off-by: Eric Huang <<a href="mailto:JinHuiEric.Huang@amd.com" target="_blank">JinHuiEric.Huang@amd.com</a>><br>
Signed-off-by: Alex Deucher <<a href="mailto:alexander.deucher@amd.com" target="_blank">alexander.deucher@amd.com</a>><br>
---<br>
<br>
This fixes OD failures on Tonga in some cases.<br>
<br>
 drivers/gpu/drm/amd/powerplay/hwmgr/tonga_hwmgr.c | 8 ++++----<br>
 1 file changed, 4 insertions(+), 4 deletions(-)<br>
<br>
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/tonga_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/tonga_hwmgr.c<br>
index cb28335..7c3f82b 100644<br>
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/tonga_hwmgr.c<br>
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/tonga_hwmgr.c<br>
@@ -5331,7 +5331,7 @@ static int tonga_freeze_sclk_mclk_dpm(struct pp_hwmgr *hwmgr)<br>
                (data->need_update_smu7_dpm_table &<br>
                (DPMTABLE_OD_UPDATE_SCLK + DPMTABLE_UPDATE_SCLK))) {<br>
                PP_ASSERT_WITH_CODE(<br>
-                       true == tonga_is_dpm_running(hwmgr),<br>
+                       0 == tonga_is_dpm_running(hwmgr),<br>
                        "Trying to freeze SCLK DPM when DPM is disabled",<br>
                        );<br>
                PP_ASSERT_WITH_CODE(<br>
@@ -5344,7 +5344,7 @@ static int tonga_freeze_sclk_mclk_dpm(struct pp_hwmgr *hwmgr)<br>
        if ((0 == data->mclk_dpm_key_disabled) &&<br>
                (data->need_update_smu7_dpm_table &<br>
                 DPMTABLE_OD_UPDATE_MCLK)) {<br>
-               PP_ASSERT_WITH_CODE(true == tonga_is_dpm_running(hwmgr),<br>
+               PP_ASSERT_WITH_CODE(0 == tonga_is_dpm_running(hwmgr),<br>
                        "Trying to freeze MCLK DPM when DPM is disabled",<br>
                        );<br>
                PP_ASSERT_WITH_CODE(<br>
@@ -5647,7 +5647,7 @@ static int tonga_unfreeze_sclk_mclk_dpm(struct pp_hwmgr *hwmgr)<br>
                (data->need_update_smu7_dpm_table &<br>
                (DPMTABLE_OD_UPDATE_SCLK + DPMTABLE_UPDATE_SCLK))) {<br>
<br>
-               PP_ASSERT_WITH_CODE(true == tonga_is_dpm_running(hwmgr),<br>
+               PP_ASSERT_WITH_CODE(0 == tonga_is_dpm_running(hwmgr),<br>
                        "Trying to Unfreeze SCLK DPM when DPM is disabled",<br>
                        );<br>
                PP_ASSERT_WITH_CODE(<br>
@@ -5661,7 +5661,7 @@ static int tonga_unfreeze_sclk_mclk_dpm(struct pp_hwmgr *hwmgr)<br>
                (data->need_update_smu7_dpm_table & DPMTABLE_OD_UPDATE_MCLK)) {<br>
<br>
                PP_ASSERT_WITH_CODE(<br>
-                               true == tonga_is_dpm_running(hwmgr),<br>
+                               0 == tonga_is_dpm_running(hwmgr),<br>
                                "Trying to Unfreeze MCLK DPM when DPM is disabled",<br>
                                );<br>
                PP_ASSERT_WITH_CODE(<br>
--<br>
2.5.5<br>
<br>
_______________________________________________<br>
dri-devel mailing list<br>
<a href="mailto:dri-devel@lists.freedesktop.org" target="_blank">dri-devel@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/dri-devel" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/dri-devel</a><br>
</blockquote></div>