On Aug 16, 2016 7:41 PM, "Yakir Yang" <<a href="mailto:ykk@rock-chips.com">ykk@rock-chips.com</a>> wrote: > > Sean, > > Thanks a lot for your good fixes. I have reviewed most of them, and all looks good to me. > > But I got a question for merging things. My PSR patch set still under reviewing, haven't been picked up Mark or other maintainers. I've picked them up in my tree. I'll send a pull request to Dave once all of the dependencies have been reviewed (marked NEEDS REVIEW). Sean > Feel a little bit embarrassed, how could we handle this situation ? > > - Yakir > > > On 08/17/2016 09:11 AM, Sean Paul wrote: >> >> This is a follow-on set to Yakir's original PSR set here: >> <a href="https://lkml.org/lkml/2016/7/24/34">https://lkml.org/lkml/2016/7/24/34</a> >> and applies to the for-next branch at: >> <a href="https://cgit.freedesktop.org/~seanpaul/dogwood">https://cgit.freedesktop.org/~seanpaul/dogwood</a> >> >> There are a few issues with the code that needed to be >> shored up. >> (1) The use of mutexes instead of spinlocks caused issues calling the >> psr functions from vblank_enable/disable. >> (2) The proliferation of workers due to (1) >> (3) A bunch of races due to (2) >> (4) vblank is not enabled unless an event is requested, this breaks >> a lot of things, but most noticeable was cursor. >> >> Changes in v2: >> - Rebased on <a href="https://cgit.freedesktop.org/~seanpaul/dogwood">https://cgit.freedesktop.org/~seanpaul/dogwood</a> >> instead of random on-list patches (some of which had drifted) >> - Added the "small fixes" patch to catch some nits >> >> >> Sean Paul (6): >> drm/rockchip: Convert psr_list_mutex to spinlock and use it >> drm/rockchip: Don't use a delayed worker for psr state changes >> drm/rockchip: Use a spinlock to protect psr state >> drm/rockchip: A couple small fixes to psr >> drm/rockchip: Improve analogix-dp psr handling >> drm/rockchip: Enable vblank without event >> >> drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 19 ++++-- >> drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 2 +- >> drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 2 +- >> drivers/gpu/drm/rockchip/rockchip_drm_psr.c | 90 ++++++++++++------------- >> drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 15 +++-- >> 5 files changed, 69 insertions(+), 59 deletions(-) >> > >