<html>
    <head>
      <base href="https://bugs.freedesktop.org/">
    </head>
    <body><table border="1" cellspacing="0" cellpadding="8">
        <tr>
          <th>Bug ID</th>
          <td><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - i915g: gl_FragCoord is always (0.0, max_y)"
   href="https://bugs.freedesktop.org/show_bug.cgi?id=97477">97477</a>
          </td>
        </tr>

        <tr>
          <th>Summary</th>
          <td>i915g: gl_FragCoord is always (0.0, max_y)
          </td>
        </tr>

        <tr>
          <th>Product</th>
          <td>Mesa
          </td>
        </tr>

        <tr>
          <th>Version</th>
          <td>git
          </td>
        </tr>

        <tr>
          <th>Hardware</th>
          <td>Other
          </td>
        </tr>

        <tr>
          <th>OS</th>
          <td>All
          </td>
        </tr>

        <tr>
          <th>Status</th>
          <td>NEW
          </td>
        </tr>

        <tr>
          <th>Severity</th>
          <td>normal
          </td>
        </tr>

        <tr>
          <th>Priority</th>
          <td>medium
          </td>
        </tr>

        <tr>
          <th>Component</th>
          <td>Drivers/Gallium/i915g
          </td>
        </tr>

        <tr>
          <th>Assignee</th>
          <td>dri-devel@lists.freedesktop.org
          </td>
        </tr>

        <tr>
          <th>Reporter</th>
          <td>nicholasbishop@gmail.com
          </td>
        </tr>

        <tr>
          <th>QA Contact</th>
          <td>dri-devel@lists.freedesktop.org
          </td>
        </tr></table>
      <p>
        <div>
        <pre>Created <span class=""><a href="attachment.cgi?id=126029" name="attach_126029" title="Patch: Handle I915_SEMANTIC_POS when setting texCoords for gl_FragCoord">attachment 126029</a> <a href="attachment.cgi?id=126029&action=edit" title="Patch: Handle I915_SEMANTIC_POS when setting texCoords for gl_FragCoord">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=97477&attachment=126029'>[review]</a>
Patch: Handle I915_SEMANTIC_POS when setting texCoords for gl_FragCoord

On Intel Pineview M hardware, the i915 gallium driver doesn't output the
correct gl_FragCoord. It seems to always have an X coord of 0.0 and a Y coord
of the window's height in pixels, e.g. 600.0f or such.

I believe this is a regression caused in part by commit
afa035031ff9e0c07a2297d864e46c76f7bfff58
(<a href="https://lists.freedesktop.org/archives/mesa-commit/2016-January/061181.html">https://lists.freedesktop.org/archives/mesa-commit/2016-January/061181.html</a>)

The old behavior used output zero, while the new behavior uses actual zeroes.
In the case of gl_FragCoord output zero happened to be the correct one.

I've attached a patch that seems to fix the issue for me. I ran the piglit
"quick" tests and observed 17 new tests passing, and one regression. I suspect
the regression is unimportant since it involves derivatives that aren't
implemented for this driver anyway:

"fs-dfdy-accuracy" test failed ... in i915_fpc_translate.c:
case TGSI_OPCODE_DDY:
      /* XXX We just output 0 here */
      debug_printf("Punting DDX/DDX\n");</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>