<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Am 14.09.2016 um 09:35 schrieb Baoyou
Xie:<br>
</div>
<blockquote
cite="mid:CA+DQWky8696GprbDNZ436pS1ASpMCRyhEL1SCsNnwDaatvW1Jw@mail.gmail.com"
type="cite">
<div dir="ltr"><br>
<div class="gmail_extra"><br>
<div class="gmail_quote">On 14 September 2016 at 15:22,
Christian König <span dir="ltr"><<a
moz-do-not-send="true" target="_blank"
href="mailto:christian.koenig@amd.com">christian.koenig@amd.com</a>></span>
wrote:<br>
<blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px
solid rgb(204,204,204);padding-left:1ex"
class="gmail_quote"><span class="gmail-">Am 14.09.2016 um
08:10 schrieb Baoyou Xie:<br>
<blockquote style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex" class="gmail_quote">
We get 2 warnings when building kernel with W=1:<br>
drivers/gpu/drm/radeon/radeon_<wbr>device.c:1961:5:
warning: no previous prototype for
'radeon_debugfs_init' [-Wmissing-prototypes]<br>
drivers/gpu/drm/radeon/radeon_<wbr>device.c:1966:6:
warning: no previous prototype for
'radeon_debugfs_cleanup' [-Wmissing-prototypes]<br>
<br>
In fact, both functions are declared in<br>
drivers/gpu/drm/radeon/radeon_<wbr>drv.c, but should
be declared in<br>
a header file, thus can be recognized in other file.<br>
<br>
So this patch moves the declarations into
drivers/gpu/drm/radeon/radeon.<wbr>h.<br>
<br>
Signed-off-by: Baoyou Xie <<a
moz-do-not-send="true" target="_blank"
href="mailto:baoyou.xie@linaro.org">baoyou.xie@linaro.org</a>><br>
</blockquote>
<br>
</span>
Actually if I see it correctly we could also just remove
the two callbacks cause they are optional and our
implementations are just empty dummys.<span
class="gmail-HOEnZb"><font color="#888888"><br>
<br>
</font></span></blockquote>
<div><br>
</div>
<div>Is it sure? if true, we can simply remove them.<br>
</div>
</div>
</div>
</div>
</blockquote>
<br>
Yeah, they are just empty skeletons as far as I can see. <br>
<br>
<blockquote
cite="mid:CA+DQWky8696GprbDNZ436pS1ASpMCRyhEL1SCsNnwDaatvW1Jw@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div><br>
</div>
<div>someone maybe implementation these functions in order
to <span>support debugfs.</span> </div>
</div>
</div>
</div>
</blockquote>
<br>
Well then someone can also add back the skeleton functions as well.<br>
<br>
Regards,<br>
Christian.<br>
<br>
<blockquote
cite="mid:CA+DQWky8696GprbDNZ436pS1ASpMCRyhEL1SCsNnwDaatvW1Jw@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div> </div>
<blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px
solid rgb(204,204,204);padding-left:1ex"
class="gmail_quote"><span class="gmail-HOEnZb"><font
color="#888888">
Christian.</font></span>
<div class="gmail-HOEnZb">
<div class="gmail-h5"><br>
<br>
<blockquote style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex"
class="gmail_quote">
---<br>
drivers/gpu/drm/radeon/radeon_<wbr>device.c | 1 +<br>
drivers/gpu/drm/radeon/radeon_<wbr>drv.c | 5
-----<br>
drivers/gpu/drm/radeon/radeon_<wbr>drv.h | 5
+++++<br>
3 files changed, 6 insertions(+), 5 deletions(-)<br>
<br>
diff --git a/drivers/gpu/drm/radeon/radeo<wbr>n_device.c
b/drivers/gpu/drm/radeon/radeo<wbr>n_device.c<br>
index a00dd2f..811abde 100644<br>
--- a/drivers/gpu/drm/radeon/radeo<wbr>n_device.c<br>
+++ b/drivers/gpu/drm/radeon/radeo<wbr>n_device.c<br>
@@ -36,6 +36,7 @@<br>
#include <linux/efi.h><br>
#include "radeon_reg.h"<br>
#include "radeon.h"<br>
+#include "radeon_drv.h"<br>
#include "atom.h"<br>
static const char radeon_family_name[][16] = {<br>
diff --git a/drivers/gpu/drm/radeon/radeo<wbr>n_drv.c
b/drivers/gpu/drm/radeon/radeo<wbr>n_drv.c<br>
index 07e4493..6cc4a9e 100644<br>
--- a/drivers/gpu/drm/radeon/radeo<wbr>n_drv.c<br>
+++ b/drivers/gpu/drm/radeon/radeo<wbr>n_drv.c<br>
@@ -156,11 +156,6 @@ void
radeon_gem_prime_vunmap(struct drm_gem_object *obj,
void *vaddr);<br>
extern long radeon_kms_compat_ioctl(struct file
*filp, unsigned int cmd,<br>
unsigned long
arg);<br>
-#if defined(CONFIG_DEBUG_FS)<br>
-int radeon_debugfs_init(struct drm_minor *minor);<br>
-void radeon_debugfs_cleanup(struct drm_minor
*minor);<br>
-#endif<br>
-<br>
/* atpx handler */<br>
#if defined(CONFIG_VGA_SWITCHEROO)<br>
void radeon_register_atpx_handler(v<wbr>oid);<br>
diff --git a/drivers/gpu/drm/radeon/radeo<wbr>n_drv.h
b/drivers/gpu/drm/radeon/radeo<wbr>n_drv.h<br>
index afef2d9..3d35e0e 100644<br>
--- a/drivers/gpu/drm/radeon/radeo<wbr>n_drv.h<br>
+++ b/drivers/gpu/drm/radeon/radeo<wbr>n_drv.h<br>
@@ -119,4 +119,9 @@<br>
long radeon_drm_ioctl(struct file *filp,<br>
unsigned int cmd, unsigned
long arg);<br>
+#if defined(CONFIG_DEBUG_FS)<br>
+int radeon_debugfs_init(struct drm_minor *minor);<br>
+void radeon_debugfs_cleanup(struct drm_minor
*minor);<br>
+#endif<br>
+<br>
#endif /*
__RADEON_DRV_H__ */<br>
</blockquote>
<br>
<br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
dri-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:dri-devel@lists.freedesktop.org">dri-devel@lists.freedesktop.org</a>
<a class="moz-txt-link-freetext" href="https://lists.freedesktop.org/mailman/listinfo/dri-devel">https://lists.freedesktop.org/mailman/listinfo/dri-devel</a>
</pre>
</blockquote>
<p><br>
</p>
</body>
</html>