<html> <head> <meta content="text/html; charset=utf-8" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> <div class="moz-cite-prefix">Patch is Reviewed-by: Christian König <a class="moz-txt-link-rfc2396E" href="mailto:christian.koenig@amd.com"><christian.koenig@amd.com></a>. Regards, Christian. Am 13.10.2016 um 09:43 schrieb Zhu, Rex: </div> <blockquote cite="mid:CY4PR12MB1687686472E61F80F9EE50E7FBDC0@CY4PR12MB1687.namprd12.prod.outlook.com" type="cite"> <pre wrap=""> Please Review. Best Regards Rex -----Original Message----- From: Dan Carpenter [<a class="moz-txt-link-freetext" href="mailto:dan.carpenter@oracle.com">mailto:dan.carpenter@oracle.com</a>] Sent: Wednesday, October 12, 2016 2:12 PM To: Zhu, Rex Cc: <a class="moz-txt-link-abbreviated" href="mailto:dri-devel@lists.freedesktop.org">dri-devel@lists.freedesktop.org</a> Subject: [bug report] drm/amd/powerplay: implement smu7 hwmgr to manager asics with smu ip version 7. Hello Rex Zhu, This is a semi-automatic email about new static checker warnings. The patch 599a7e9fe1b6: "drm/amd/powerplay: implement smu7 hwmgr to manager asics with smu ip version 7." from Sep 9, 2016, leads to the following Smatch complaint: drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/smu7_hwmgr.c:1463 smu7_get_evv_voltages() error: we previously assumed 'table_info' could be null (see line 1455) drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/smu7_hwmgr.c 1454 1455 if (table_info != NULL) ^^^^^^^^^^^^^^^^^ Check for non-NULL. 1456 sclk_table = table_info->vdd_dep_on_sclk; 1457 1458 for (i = 0; i < SMU7_MAX_LEAKAGE_COUNT; i++) { 1459 vv_id = ATOM_VIRTUAL_VOLTAGE_ID0 + i; 1460 1461 if (data->vdd_gfx_control == SMU7_VOLTAGE_CONTROL_BY_SVID2) { 1462 if (0 == phm_get_sclk_for_voltage_evv(hwmgr, 1463 table_info->vddgfx_lookup_table, vv_id, &sclk)) { ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Unchecked dereference. 1464 if (phm_cap_enabled(hwmgr->platform_descriptor.platformCaps, 1465 PHM_PlatformCaps_ClockStretcher)) { regards, dan carpenter </pre> <fieldset class="mimeAttachmentHeader"></fieldset> <pre wrap="">_______________________________________________ dri-devel mailing list <a class="moz-txt-link-abbreviated" href="mailto:dri-devel@lists.freedesktop.org">dri-devel@lists.freedesktop.org</a> <a class="moz-txt-link-freetext" href="https://lists.freedesktop.org/mailman/listinfo/dri-devel">https://lists.freedesktop.org/mailman/listinfo/dri-devel</a> </pre> </blockquote> </body> </html>