<html> <head> <meta content="text/html; charset=utf-8" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> Thanks for comments. <div class="moz-cite-prefix">On 10/20/2016 2:15 PM, Wolfram Sang wrote: </div> <blockquote cite="mid:20161020084535.GA1442@katana" type="cite"> <pre wrap=""> </pre> <blockquote type="cite"> <blockquote type="cite"> <pre wrap="">IMO it would be better to use id->driver_data unconditionally and save a call to of_device_get_match_data() What would you suggest to move ahead? </pre> </blockquote> <pre wrap=""> I'd suggest using id->driver_data unconditionally, but I'd like Wolfram's opinion on this (CC'ed). </pre> </blockquote> <pre wrap=""> IIUC: I'd suggest to leave it as it is. There are people working on removing the quirky fallback to i2c_device_id in case of_compatible is not provided. If that gets mainline, you don't have i2c_device_id anymore with DT matching. So all binding methods should be self-contained.</pre> </blockquote> ok Should we leave as it is, redundant if-else code block also, or fix it as posted in patch v2 <blockquote cite="mid:20161020084535.GA1442@katana" type="cite"> <pre wrap=""> </pre> <fieldset class="mimeAttachmentHeader"></fieldset> <pre wrap="">_______________________________________________ dri-devel mailing list <a class="moz-txt-link-abbreviated" href="mailto:dri-devel@lists.freedesktop.org">dri-devel@lists.freedesktop.org</a> <a class="moz-txt-link-freetext" href="https://lists.freedesktop.org/mailman/listinfo/dri-devel">https://lists.freedesktop.org/mailman/listinfo/dri-devel</a> </pre> </blockquote> </body> </html>