<div dir="ltr"> <div class="gmail_extra"> <div class="gmail_quote">On 25 October 2016 at 16:15, Arnd Bergmann <<a href="mailto:arnd@arndb.de" target="_blank">arnd@arndb.de</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Tuesday, October 25, 2016 10:31:21 AM CEST Baoyou Xie wrote: > On 25 October 2016 at 04:51, Arnd Bergmann <<a href="mailto:arnd@arndb.de">arnd@arndb.de</a>> wrote: > > On Saturday, October 22, 2016 4:56:22 PM CEST Baoyou Xie wrote: > > The function has no callers, so the easiest way would be to remove it > > entirely, but it's possible that there are plans to add users soon. > > > > It was assumed that this function will be used soon, so this patch remains > it. > if it still not be used in 4.10, then we can remove it. > is it right? There is no such rule in general, it's up to the maintainer and it depends on the specific reason for why the function ended up being unused in the first place. However, we can expect the maintainer to come up with some solution to address the warning. Possible options include: - calling the function from where it was meant to be used - removing the function - adding __maybe_unused - adding an #if 0 I have not looked at this specific example and do not know which of them would be appropriate here. If you look at the output of 'git log -p drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/smu7_hwmgr.c' you might find it out yourself. </blockquote><div> Good idea :) </div><div>hi, Daniel: could you tell me the git tree that you use? it's better to work on your git tree. </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Arnd </blockquote></div> </div></div>