<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_ASSIGNED " title="ASSIGNED - VCE dual instance encoding inconsistent since st/va: enable dual instances encode by sync surface" href="https://bugs.freedesktop.org/show_bug.cgi?id=98005#c8">Comment # 8</a> on <a class="bz_bug_link bz_status_ASSIGNED " title="ASSIGNED - VCE dual instance encoding inconsistent since st/va: enable dual instances encode by sync surface" href="https://bugs.freedesktop.org/show_bug.cgi?id=98005">bug 98005</a> from <a class="email" href="mailto:boyuan.zhang@amd.com" title="Boyuan Zhang <boyuan.zhang@amd.com>"> Boyuan Zhang</a> <pre>(In reply to Andy Furniss from <a href="show_bug.cgi?id=98005#c7">comment #7</a>) > (In reply to Boyuan Zhang from <a href="show_bug.cgi?id=98005#c6">comment #6</a>) > > Hi Andy, > > > > I just submitted 2 reviews for fixing the bit-rate issue. The 2 patches can > > be found at > > <a href="https://lists.freedesktop.org/archives/mesa-dev/2016-November/134944.html">https://lists.freedesktop.org/archives/mesa-dev/2016-November/134944.html</a> > > > > 0001-st/va: force to submit two consecutive single jobs > > 0002-st/va: fix gop size for rate control > > > > Please give a try and let me know how it works. > > > > Regards, > > Boyuan > > Hi, I can't get those to apply to current mesa head. > > Checking patch src/gallium/state_trackers/va/picture.c... > Hunk #1 succeeded at 413 (offset 1 line). > Hunk #2 succeeded at 568 (offset 1 line). > Checking patch src/gallium/state_trackers/va/surface.c... > error: while searching for: > > if (context->decoder->entrypoint == PIPE_VIDEO_ENTRYPOINT_ENCODE) { > int frame_diff; > if (context->desc.h264enc.frame_num_cnt > surf->frame_num_cnt) > frame_diff = context->desc.h264enc.frame_num_cnt - > surf->frame_num_cnt; > else > frame_diff = 0xFFFFFFFF - surf->frame_num_cnt + 1 + > context->desc.h264enc.frame_num_cnt; > if (frame_diff < 2) > context->decoder->flush(context->decoder); > context->decoder->get_feedback(context->decoder, surf->feedback, > &(surf->coded_buf->coded_size)); > } > pipe_mutex_unlock(drv->mutex); > > error: patch failed: src/gallium/state_trackers/va/surface.c:119 > error: src/gallium/state_trackers/va/surface.c: patch does not apply > Checking patch src/gallium/state_trackers/va/va_private.h... > Hunk #2 succeeded at 275 (offset 1 line). > > and > > Checking patch src/gallium/state_trackers/va/picture.c... > Hunk #1 succeeded at 351 (offset 1 line). > error: while searching for: > context->desc.h264enc.not_referenced = false; > context->desc.h264enc.is_idr = (h264->pic_fields.bits.idr_pic_flag == 1); > context->desc.h264enc.pic_order_cnt = h264->CurrPic.TopFieldOrderCnt / 2; > if (context->desc.h264enc.is_idr) > context->desc.h264enc.i_remain = 1; > else > context->desc.h264enc.i_remain = 0; > > context->desc.h264enc.p_remain = context->desc.h264enc.gop_size - > context->desc.h264enc.gop_cnt - context->desc.h264enc.i_remain; > > > error: patch failed: src/gallium/state_trackers/va/picture.c:390 > error: src/gallium/state_trackers/va/picture.c: patch does not apply > Checking patch src/gallium/state_trackers/va/va_private.h... Hi Andy, Sorry about that. Just rebased my codes. Please find the new patches here: <a href="https://lists.freedesktop.org/archives/mesa-dev/2016-November/135076.html">https://lists.freedesktop.org/archives/mesa-dev/2016-November/135076.html</a> <a href="https://lists.freedesktop.org/archives/mesa-dev/2016-November/135077.html">https://lists.freedesktop.org/archives/mesa-dev/2016-November/135077.html</a> Regards, Boyuan</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>