<div dir="ltr">Did we forget about this one? I guess I could commit it myself, but I'm not sure which branch to push it too...<div><br></div><div>Kristian<br><br><div class="gmail_quote"><div dir="ltr">On Wed, Nov 9, 2016 at 4:10 PM Kristian Kristensen <<a href="mailto:hoegsberg@google.com">hoegsberg@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="gmail_msg"><div class="gmail_extra gmail_msg"><div class="gmail_quote gmail_msg">On Wed, Nov 9, 2016 at 4:36 AM, Daniel Vetter <span dir="ltr" class="gmail_msg"><<a href="mailto:daniel.vetter@ffwll.ch" class="gmail_msg" target="_blank">daniel.vetter@ffwll.ch</a>></span> wrote:<br class="gmail_msg"><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Not setting the fb modifiers flag is something different from setting<br class="gmail_msg">
the fb modifiers to 0 (which means explicitly linear). We kinda failed<br class="gmail_msg">
to document that properly. Spotted by Kristian.<br class="gmail_msg">
<br class="gmail_msg">
Cc: <a href="mailto:hoegsberg@google.com" class="gmail_msg" target="_blank">hoegsberg@google.com</a><br class="gmail_msg">
Signed-off-by: Daniel Vetter <<a href="mailto:daniel.vetter@ffwll.ch" class="gmail_msg" target="_blank">daniel.vetter@ffwll.ch</a>><br class="gmail_msg">
</blockquote><div class="gmail_msg"><br class="gmail_msg"></div></div></div></div><div dir="ltr" class="gmail_msg"><div class="gmail_extra gmail_msg"><div class="gmail_quote gmail_msg"><div class="gmail_msg">Thanks, looks good.</div><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">Reviewed-by: Kristian H. Kristensen <<a href="mailto:hoegsberg@google.com" class="gmail_msg" target="_blank">hoegsberg@google.com</a>></div></div></div></div><div dir="ltr" class="gmail_msg"><div class="gmail_extra gmail_msg"><div class="gmail_quote gmail_msg"><div class="gmail_msg"> </div><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">---<br class="gmail_msg">
 include/uapi/drm/drm_fourcc.h | 10 ++++++++++<br class="gmail_msg">
 1 file changed, 10 insertions(+)<br class="gmail_msg">
<br class="gmail_msg">
diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h<br class="gmail_msg">
index da49f69e4d7e..2fca7e1f6aab 100644<br class="gmail_msg">
--- a/include/uapi/drm/drm_fourcc.h<br class="gmail_msg">
+++ b/include/uapi/drm/drm_fourcc.h<br class="gmail_msg">
@@ -172,6 +172,16 @@ extern "C" {<br class="gmail_msg">
  * authoritative source for all of these.<br class="gmail_msg">
  */<br class="gmail_msg">
<br class="gmail_msg">
+/*<br class="gmail_msg">
+ * Linear Layout<br class="gmail_msg">
+ *<br class="gmail_msg">
+ * Just plain linear layout. Note that this is different from no specifying any<br class="gmail_msg">
+ * modifier (e.g. not setting DRM_MODE_FB_MODIFIERS in the DRM_ADDFB2 ioctl),<br class="gmail_msg">
+ * which tells the driver to also take driver-internal information into account<br class="gmail_msg">
+ * and so might actually result in a tiled framebuffer.<br class="gmail_msg">
+ */<br class="gmail_msg">
+#define DRM_FORMAT_MOD_LINEAR  fourcc_mod_code(NONE, 0)<br class="gmail_msg">
+<br class="gmail_msg">
 /* Intel framebuffer modifiers */<br class="gmail_msg">
<br class="gmail_msg">
 /*<br class="gmail_msg">
<span class="m_6726987626071526788HOEnZb gmail_msg"><font color="#888888" class="gmail_msg">--<br class="gmail_msg">
2.7.4<br class="gmail_msg">
<br class="gmail_msg">
</font></span></blockquote></div></div></div>
_______________________________________________<br class="gmail_msg">
dri-devel mailing list<br class="gmail_msg">
<a href="mailto:dri-devel@lists.freedesktop.org" class="gmail_msg" target="_blank">dri-devel@lists.freedesktop.org</a><br class="gmail_msg">
<a href="https://lists.freedesktop.org/mailman/listinfo/dri-devel" rel="noreferrer" class="gmail_msg" target="_blank">https://lists.freedesktop.org/mailman/listinfo/dri-devel</a><br class="gmail_msg">
</blockquote></div></div></div>