<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Arial,Helvetica,sans-serif;" dir="ltr"> <p><font size="2"><span style="font-size:10pt;">Tested-by: Breno Lima <breno.lima@nxp.com></span></font><br> </p> <br> <br> <div style="color: rgb(0, 0, 0);"> <div> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="x_divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" color="#000000" face="Calibri, sans-serif"><b>From:</b> Thierry Reding <thierry.reding@gmail.com><br> <b>Sent:</b> Wednesday, February 1, 2017 3:22 PM<br> <b>To:</b> Fabio Estevam<br> <b>Cc:</b> airlied@linux.ie; marex@denx.de; dri-devel@lists.freedesktop.org; Breno Matheus Lima<br> <b>Subject:</b> Re: [PATCH] drm: mxsfb: Implement drm_panel handling</font> <div> </div> </div> </div> <font size="2"><span style="font-size:10pt;"> <div class="PlainText">On Wed, Feb 01, 2017 at 03:19:47PM -0200, Fabio Estevam wrote:<br> > Currently when the 'power-supply' regulator is passed via device tree<br> > it does not actually work since drm_panel_prepare()/drm_panel_enable()<br> > are never called.<br> > <br> > Quoting Thierry Reding: "It should really call drm_panel_prepare() and<br> > drm_panel_enable() while switching on the display pipeline and<br> > drm_panel_disable(), followed by drm_panel_unprepare() while switching<br> > off the display pipeline."<br> > <br> > So do as suggested, so that the 'power-supply' regulator can be functional.<br> > <br> > Reported-by: Breno Lima <breno.lima@nxp.com><br> > Suggested-by: Thierry Reding <thierry.reding@gmail.com><br> > Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com><br> > ---<br> > drivers/gpu/drm/mxsfb/mxsfb_drv.c | 4 ++++<br> > 1 file changed, 4 insertions(+)<br> <br> Reviewed-by: Thierry Reding <treding@nvidia.com><br> </div> </span></font></div> </div> </body> </html>